Allow user to choose plotting library#928
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 92.13% 92.93% +0.79%
===========================================
Files 74 79 +5
Lines 5799 6367 +568
===========================================
+ Hits 5343 5917 +574
+ Misses 456 450 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NicolaCourtier
left a comment
There was a problem hiding this comment.
This is excellent, thanks @SarahRo !
Some minor comments and questions:
- do you think we should deprecate
StandardPlotandStandardSubplotin favour of the standardised backend functionality, since they only seem to be used once each? - there seems to be an issue with the Voronoi plot in
optimising_with_scipy_minimize.pyalthough it works elsewhere, please could you check if this is due to changes made in this PR?
I'm looking into this. I simplified the voronoi plot when replicating it in matplotlib so that is likely what is causing the issue. It must be a bit of an edge case since it's working for most examples. I will also look into the changes required for deprecating |
Co-authored-by: NicolaCourtier <45851982+NicolaCourtier@users.noreply.github.com>
NicolaCourtier
left a comment
There was a problem hiding this comment.
Looks great, thanks @SarahRo !
Description
This PR adds the following features:
plotlyormatplotlib.pyplotas the plotting backend.backend = ...to the plotting function.Fixes #855
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)nox -s testsnox -s doctest