Site: Improve challenge transfer edge cases #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Challenge transfer logic has some interesting edge cases, this PR seeks to clarify them a bit.
In particular, the edge case that led to this PR is the case where someone creates a challenge, then realizes what they actually wanted to do was transfer a challenge. Under the current logic, the transfer will not happen because the challenge already exists, and so it will never enter the transfer logic. Transfer logic should take priority.
However, if there is an existing challenge, we have to be careful, and have some options:
For now, we will just refuse and throw an error.