update support for Ubuntu 24.04 #726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relying on Ubuntu full containing the month number works fine for specific versions, but makes it hard to use versioncmp. this patch does not change behaviour
bastelfreak
reviewed
Jun 12, 2025
data/Debian-12.yaml
Outdated
| ntp::package_name: | ||
| - ntpsec | ||
| ntp::config: '/etc/ntpsec/ntp.conf' | ||
|
|
There was a problem hiding this comment.
please remove the empty line
kjetilho
force-pushed
the
feature/ubuntu-24.04
branch
2 times, most recently
from
93a178a to
971d9e8
Compare
both of these have "ntp" as a transitional package which installs "ntpsec", but setting package_name explicitly is cleaner and allows easier keying of how to configure the system.
kjetilho
force-pushed
the
feature/ubuntu-24.04
branch
from
9f286ec to
b432117
Compare
|
I don't think the failing tests are something I can fix? I don't see any action points, at least. please let me know if there is something I can do. |
|
On my ubuntu 24.04 server I also needed to update the driftfile location due to new AppArmor rules: ntp::driftfile: '/var/lib/ntpsec/ntp.drift' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ubuntu 24.04 uses the ntpsec package to manage the ntp service.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)