Skip to content

Update conditional logic xtrabackup.pp to properly... - #1609

Merged
bronachfalls merged 1 commit into
puppetlabs:mainfrom
ndelic0:(GH-1589)-MariaDB-changed-REPLICATION-CLIENT-grant-to-BINLOG-MONITOR
Aug 18, 2026
Merged

bronachfalls merged 1 commit into
puppetlabs:mainfrom
ndelic0:(GH-1589)-MariaDB-changed-REPLICATION-CLIENT-grant-to-BINLOG-MONITOR

Conversation

@ndelic0

@ndelic0 ndelic0 commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Summary

Update conditional logic xtrabackup.pp to properly manage permissions of xtrabackup users for MariaDB 10.5.2

Additional Context

Check #1598

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@ndelic0
ndelic0 requested review from a team, alexjfisher and bastelfreak as code owners December 8, 2023 12:06
@CLAassistant

CLAassistant commented Dec 8, 2023 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@optiz0r optiz0r left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this PR in production for >18 months. Forgot all about it, but had to come back and re-apply this to puppetlabs-mysql 16.2 after upgrading puppet, finding it still unmerged. Would be lovely if Perforce could merge and release this.

@robbevl

robbevl commented Jun 6, 2026

Copy link
Copy Markdown

Merge please, this is a simple bugfix for one that is troubling me as well.

@jst-cyr

jst-cyr commented Jun 17, 2026

Copy link
Copy Markdown
Member

@ndelic0 and @robbevl : Thanks for the PR here! I've added it to the list for the engineering team to review as we move through the backlog of module requests. This looks like a good addition to include!

@ndelic0

ndelic0 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@alexjfisher @bastelfreak kind request for review

@bronachfalls
bronachfalls force-pushed the (GH-1589)-MariaDB-changed-REPLICATION-CLIENT-grant-to-BINLOG-MONITOR branch from 45210e8 to ebe0268 Compare August 18, 2026 13:02
@bronachfalls
bronachfalls merged commit 08f8562 into puppetlabs:main Aug 18, 2026
6 checks passed
@bronachfalls
bronachfalls deployed to puppetcore-fork August 18, 2026 13:06 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
puppetcore-fork — ebe02681 Deployed Aug 18, 2026 by bronachfalls via Acceptance / Fork PR approval gate #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants