Skip to content

Use cached get() results to limit calls to get() #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use cached get() results to limit calls to get() #346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f1f05a
Use cached get() results to limit calls to get()
amandaharth Apr 12, 2024
67d839a
Use unless, instead of negated if
amandaharth Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet/resource_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def to_resource_shim(resource)
def self.rsapi_provider_get(names = nil)
# If the cache has been marked as having all instances, then just return the
# full contents:
return rsapi_provider_get_cache.all if rsapi_provider_get_cache.cached_all? && names.nil?
return rsapi_provider_get_cache.all if rsapi_provider_get_cache.cached_all?

fetched = if type_definition.feature?('simple_get_filter')
my_provider.get(context, names)
Expand All @@ -265,7 +265,7 @@ def self.rsapi_provider_get(names = nil)
rsapi_provider_get_cache.add(build_title(type_definition, resource_hash), resource_hash)
end

if names.nil? && !type_definition.feature?('simple_get_filter')
unless type_definition.feature?('simple_get_filter')
# Mark the cache as having all possible instances:
rsapi_provider_get_cache.cached_all
end
Expand Down