TASK: prevent setProperty from running multiple times on one update#26
Open
batabana wants to merge 1 commit intopunktDe:masterfrom
Open
TASK: prevent setProperty from running multiple times on one update#26batabana wants to merge 1 commit intopunktDe:masterfrom
batabana wants to merge 1 commit intopunktDe:masterfrom
Conversation
batabana
force-pushed
the
task/improve-performance
branch
from
a8cca2d to
765a645
Compare
erickloss
reviewed
Jun 13, 2022
| * @param NodeInterface $node | ||
| * @return array|null | ||
| */ | ||
| protected static function getExcludedProperties(NodeInterface $node): ?array |
There was a problem hiding this comment.
ist das korrekt, dass die rausfliegt?
Contributor
Author
There was a problem hiding this comment.
ich denke, weil den config key "excludeProperties" gibts in der neuen version eigentlich nicht mehr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating to the new release changes on properties of type 'references' kept on taking very long. On checking the logs we saw a very huge amount of update messages for this one property, repeatedly for all dimensions. This was also happening in a much smaller scope for simple string properties. Apparently setting a property kept on emitting the nodePropertyChanged signal and sent us into too many repetitions.