Conversation
Point git_override at avrabe/rules_rust fix/windows-libpath-quoting branch (commit 732695b6) which quotes LIBPATH paths containing spaces in the bootstrap_process_wrapper.bat script. This should fix the persistent Windows CI failure: LNK1181 cannot open input file librustc_std_workspace_alloc.rlib Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Windows LIBPATH quoting fix doesn't fully resolve LNK1181. Two separate issues found:
Closing to iterate on the fork. Will reopen when the fix covers both code paths. |
Combine both fixes for Windows LNK1181: 1. rules_rust fork with LIBPATH quoting (MODULE.bazel) 2. Short output_base D:\_b to avoid MAX_PATH limit (ci.yml) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Not needed — the LNK1181 was purely a MAX_PATH issue, fixed by short output_base in #413. The LIBPATH quoting fix isn't required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines two fixes for the persistent Windows LNK1181 error:
avrabe/rules_rustfix/windows-libpath-quotingbranch which quotes paths with spaces inbootstrap_process_wrapper.bat--output_base=D:\_bto avoid Windows MAX_PATH (260 char) limit — the rlib paths are ~250 chars with the default output_baseTest plan
Test on windows-latestpasses with both fixes combined🤖 Generated with Claude Code