Conversation
…orwarding Adds resource_rep_by_component and resource_new_by_component maps to MergedModule, populated during add_unresolved_imports. The adapter generator uses these to find the correct component's [resource-rep] and [resource-new] in multi-component chains. For resource_floats, the adapter now correctly generates: caller_resource_rep(handle) → rep → callee_resource_new(rep) → new_handle The remaining blocker is a P2 wrapper resource type mismatch: the [resource-new] and [resource-rep] for the intermediate component's exports instance are backed by different resource types. Also extends synthesize_missing_resource_imports to synthesize callee's [resource-new] for 3-component chains. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource_rep_by_componentandresource_new_by_componentmaps toMergedModuleadd_unresolved_importswhen processing[resource-rep]/[resource-new]function imports[resource-rep]for caller and[resource-new]for calleesynthesize_missing_resource_importsto synthesize callee's[resource-new]for 3-component chainsProgress on resource_floats
The adapter now correctly generates:
caller_resource_rep(handle) → rep → callee_resource_new(rep) → new_handleRemaining blocker: P2 wrapper resource type mismatch — the
[resource-new]and[resource-rep]for the intermediate's exports instance are backed by different resource type definitions. This is acomponent_wrap.rsissue.Test plan
🤖 Generated with Claude Code