Conversation
…llback path Bug 1: AdapterSite now tracks the caller's core import module name (import_module field) so the merger disambiguates same-named functions from different interfaces. Previously .find() matched on bare function name only, wiring both e.g. "test:e1#a" and "test:e2#a" to the same adapter when both export a function named "a". Bug 2: The single-export fallback resolver path now uses lift_info_by_core_func (which provides the component type index) instead of lift_options_by_core_func. This enables populating resource_params, pointer pair positions, copy layouts, and all other AdapterRequirements fields that were previously only set in the per-function interface matching path. Promotes 4 fixtures from fuse-only to runtime: resource_alias, with-and-resources, versions, xcrate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdapterSitenow tracksimport_module(the caller's core import module name) to disambiguate same-named functions from different interfaces. Previously.find()matched on bare function name only.lift_info_by_core_functo populateresource_params, pointer pair positions, copy layouts, and all otherAdapterRequirementsfields.Fixtures promoted to runtime (4)
resource_alias— two interfaces with function named "a"with-and-resources— two interfaces with function named "bar"versions— versioned interfaces@0.1.0/@0.2.0with same function namesxcrate— 3-component chain with resources resolved via fallback pathTest plan
🤖 Generated with Claude Code