fix: memory64, GC struct/array refs, misc validation#162
Merged
Conversation
…code Memory64 support (~934 tests): - Change MemArg.offset from u32 to u64 - Add read_leb128_u64 for offset parsing - Accept i64 addresses in all load/store/bulk memory ops - memory.size/grow return/accept i64 for memory64 memories - Handle i64 data segment offsets - Cap initial allocation to prevent OOM on huge memory64 modules GC struct/array reference semantics (~70 tests): - Use Arc<Mutex<>> for shared heap-backed struct/array references - Fix DefaultMemoryProvider to use heap-backed Vec in std mode - Add GcStorageType::RefType/RefTypeNull for concrete type indices - Fix BrOnCast/BrOnCastFail null handling flags - Fix ArrayNewDefault element type defaults Misc validation (~15 tests): - Fix unreachable code stack handling for ref.is_null, ref.as_non_null, br_on_null - Fix select validation in unreachable code - Fix custom page size validation (only exponents 0 and 16 valid) - Fix BrOnNull/BrOnNonNull multi-value branch handling - Add page_size compatibility check for memory imports WAST conformance: 63,806 → 64,820 passed (+1,014), 1,836 → 822 failed. Total assertions verified: 65,642 (unchanged — no tests skipped). Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Trace: skip
🤖 Generated with Claude Code