fix: implement threads/atomics instruction parsing and validation#161
Merged
fix: implement threads/atomics instruction parsing and validation#161
Conversation
Add complete 0xFE prefix handler for all 79 atomic instruction opcodes: - memory.atomic.notify/wait32/wait64, atomic.fence - Atomic loads/stores (i32/i64, 8/16/32-bit variants) - Atomic RMW ops (add/sub/and/or/xor/xchg/cmpxchg, all width variants) Add validator support for all atomic instructions with correct stack effects. Add spectest shared_memory import support. Execution was already implemented — this enables parsing and validation so modules can actually load and run. WAST conformance: 63,806 → 64,056 passed (+250). Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Trace: skip
🤖 Generated with Claude Code