fix(validator,gc): unreachable stack truncation and GC instruction fixes#157
Merged
fix(validator,gc): unreachable stack truncation and GC instruction fixes#157
Conversation
Validator: Always truncate operand stack after terminating instructions (unreachable, throw, br, return, etc.) even in already-unreachable code. Previously, values pushed between consecutive terminating instructions accumulated, causing false "type mismatch" errors at block end. Fixes select.wast (+125), block.wast (+53), loop.wast (+79) and other tests with unreachable code patterns. GC: Fix ref.eq to handle i31ref (value equality), structref/arrayref (identity comparison), and cross-type null comparisons. Fix ref.i31 to use mask instead of shift. Fix i31.get_s sign extension from bit 30. WAST conformance: 62,626 → 62,788 passed (+162), 3,016 → 2,854 failed. Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unreachable/br/returninstructions were accumulating and causing false "type mismatch" at block endref.eqto handle i31ref (value equality), structref/arrayref (identity comparison), and cross-type null comparisonsref.i31to use mask (& 0x7FFFFFFF) instead of shifti31.get_sto properly sign-extend from bit 30Test plan
Trace: skip
🤖 Generated with Claude Code