config: Support coalesced explicit and SPM flushes - #22
Merged
Merged
Conversation
The current implementation assumes that a flush is triggered either by a write to `cfg_flush` *or* to `cfg_spm`, but never to both at the same time. In particular, when reconfiguring a way from SPM to LLC while any bit of `cfg_flush` is set, this can cause this way to remain marked as `flushed` and functioning neither as SPM nor LLC. In our scenario, the LLC was still in bypass mode even though some ways have been configured as LLC. Fix this by reducing the if/else block to an invariant. Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
thommythomaso
approved these changes
Jul 9, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation assumes that a flush is triggered either by a write to
cfg_flushor tocfg_spm, but never to both at the same time. In particular, when reconfiguring a way from SPM to LLC while any bit ofcfg_flushis set, this can cause this way to remain marked asflushedand function neither as SPM nor LLC. In our scenario, the LLC was still in bypass mode even though some ways had been configured as LLC.Fix this by reducing the if/else block to an invariant.