Increase recursion depth limits by factor of 100 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiply all type checker recursion depth limits by 100 to allow deeper type nesting: - inference.go: 2 → 200 (type inference recursion) - relater.go: 3 → 300 (type relation recursion), 10 → 1000 (conditional type nesting)
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Multiplies all type checker recursion depth limits by 100 to allow significantly deeper type nesting:
inference.go:2→200(type inference recursion checks)relater.go:3→300(type relation recursion checks),10→1000(conditional type nesting)Changes
Updated the
maxDepthparameters in calls toisDeeplyNestedType:internal/checker/inference.go: Two occurrences (lines 351, 354, 1005, 1008)internal/checker/relater.go: Four occurrences (lines 3064, 3070, 3488, 3669)Test Plan
Context
These limits control when the type checker stops recursing through deeply nested types to prevent infinite loops. Increasing them allows more complex type definitions to be processed before hitting recursion limits.