-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update minimum Node.js version to 22, updates dependencies #5433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.0-develop
Are you sure you want to change the base?
Conversation
0efa6c5 to
6d0818d
Compare
| "build": "cross-env NODE_ENV=development ./node_modules/.bin/webpack --progress", | ||
| "build:production": "yarn run clean && cross-env NODE_ENV=production ./node_modules/.bin/webpack --mode production", | ||
| "serve": "yarn run clean && cross-env WEBPACK_PUBLIC_PATH=/webpack@hmr/ NODE_ENV=development webpack-dev-server --host 0.0.0.0 --port 8080 --public https://pterodactyl.test --hot" | ||
| "build:production": "yarn run clean && cross-env NODE_ENV=production NODE_OPTIONS=--openssl-legacy-provider ./node_modules/.bin/webpack --mode production", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As webpack was updated, this change is no longer needed
[nix-shell:~/repos/panel]# node -v
v22.20.0
[nix-shell:~/repos/panel]# yarn build:production
yarn run v1.22.22
$ yarn run clean && cross-env NODE_ENV=production ./node_modules/.bin/webpack --mode production
...
Done in 13.62s.
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Build | ||
| run: yarn build:production | ||
| - run: yarn tsc | ||
| - run: yarn lint | ||
| - run: yarn build:production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Install dependencies | |
| run: yarn install --frozen-lockfile | |
| - name: Build | |
| run: yarn build:production | |
| - run: yarn tsc | |
| - run: yarn lint | |
| - run: yarn build:production | |
| - name: Install & Build dependencies | |
| run: | | |
| yarn install --frozen-lockfile | |
| yarn tsc | |
| yarn lint | |
| yarn build:production |
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - run: yarn tsc | ||
| - run: yarn lint | ||
| - name: Build | ||
| run: yarn build:production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Install dependencies | |
| run: yarn install --frozen-lockfile | |
| - run: yarn tsc | |
| - run: yarn lint | |
| - name: Build | |
| run: yarn build:production | |
| - name: Install & Build dependencies | |
| run: | | |
| yarn install --frozen-lockfile | |
| yarn tsc | |
| yarn lint | |
| yarn build:production |
| "i18next": "^21.8.9", | ||
| "i18next-http-backend": "^1.4.1", | ||
| "i18next-multiload-backend-adapter": "^1.0.0", | ||
| "pathe": "^2.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A package is required here as the node: protocol isn't accessible on the frontend. You would need to polyfill it which needs an external library and in result the asset will be much bigger than just using pathe
This PR updates the codebase to support Node 22 as the minimum version and updates many of the dependencies to either their latest version, or the latest version of the defined major grouping. This addresses many of the audit warnings for various security vulnerabilities and should ensure we have an easier time maintaining and upgrading packages down the road since it has been quite some time since things were updated here.
I didn't get a chance to test these changes against most of the server pages because of some Docker annoyances on my local that I need to sort out first.
Other Notes
tsc --noEmitbefore builds in CI to verify no issues.Note
There are a bunch of little commits because that was the easiest way to slowly update while checking builds each time. Recommend squash merging this PR into
1.0-developso it is one update.