fix: brew README, tagged updates, behavioral tests, CI - #70
Merged
Conversation
README no longer tells brew users to run a missing libexec/install.sh. Installer version checks and --update follow GitHub releases/latest (same pin as the update module and brew livecheck) and refuse Homebrew prefixes. Tests exercise parse_args, version_lt, and argv forwarding through a stubbed re-exec. CI runs tests/test_*.sh and shellcheck. Closes #66 Closes #67 Closes #68 Closes #69
apt ShellCheck reports useless-cat (SC2002) that the local binary did not. Track it with the other leftover codes instead of a drive-by rewrite of VERSION readers.
pstuart
added a commit
that referenced
this pull request
Aug 30, 2026
* fix: brew docs, tagged --update, update tests, and CI README no longer tells brew users to run a missing libexec/install.sh. Installer version checks and --update follow GitHub releases/latest (same pin as the update module and brew livecheck) and refuse Homebrew prefixes. Tests exercise parse_args, version_lt, and argv forwarding through a stubbed re-exec. CI runs tests/test_*.sh and shellcheck. Closes #66 Closes #67 Closes #68 Closes #69 * fix(ci): allow SC2002 so Ubuntu ShellCheck matches local baseline apt ShellCheck reports useless-cat (SC2002) that the local binary did not. Track it with the other leftover codes instead of a drive-by rewrite of VERSION readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements open issues #66–#69 on one conservative branch.
libexec/install.sh(the formula does not ship it). First-run steps match tap caveats:statusLine.command→opt/barista/libexec/barista.sh, thenbarista config.--skip-update-checkis documented. Uninstall distinguishesbrew uninstallvs./install.sh --uninstall.check_remote_version/do_updateuse GitHubreleases/latest(same source asmodules/update.shand brewlivecheck). Git checkout usesv$REMOTE_VERSION; zip usesarchive/refs/tags/vX.Y.Z.zipand checksVERSION. Homebrew Cellar/opt prefixes are refused (brew upgrade barista).version_ltuses the same numeric/prerelease sanitizing as_version_gt.tests/test_install_update.shsourcesinstall.sh(main skipped), assertsparse_args,version_lt(including1.9vs1.10), brew refusal, and_reexec_installerargv after a stubbed successful update..github/workflows/ci.ymlonpush/pull_requesttomain,contents: read, pinnedactions/checkout@v4.2.2SHA, alltests/test_*.sh,shellcheck -xwith remaining codes listed in.shellcheckrc.Test plan
bash tests/test_*.shlocally (all pass)shellcheck -x install.sh barista.sh modules/*.sh lib/*.sh(exit 0)libexec/install.sh./install.sh --updateon a brew prefix would refuse (unit-tested)