Queue Topology Update#48
Merged
Merged
Conversation
This reverts commit 00eef6d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
By v0 topology, we refer to the rabbitmq/celery topology which exists in the "main" branch. This topology consists of one queue and one exchange, and does not support DLQ or priority capabilities.
This PR applies a minor version update to common, client, and server against the "main" branch, and applies permanent topology changes to address architectural issues to PixivUtil server. If the current minor version of "main" is X, then the version with this PR shall be X+1.
Implement DLQ and 3-tier priority queue v1 topology + permanent upgrade to v1 from v0 during worker init. If v0 has messages these messages will be deleted. No logic will be included for this migration to save messages.
DLQ exists only to handle network-related exceptions that arise from an internet blackout, not to handle privated/deleted artworks or unauth exceptions. Any other error will discard message as normal.
Migration and architecture changes apply only to the "main" branch.