MNT: Use policy_max in cmake_minimum_required - #51
Merged
pshriwise merged 1 commit intoFeb 13, 2026
Conversation
* Set policy_max which defines the maximum CMake policy. cmake_minimum_required sets two minimums: the real (lower) minimum and the (upper) minimum based on has been tested with. The defaults (CMake policies) will be set to the highest value possible between the two values. - c.f. https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
Contributor
Author
|
👋 @pshriwise this is ready for review. Let me know if you have any questions. |
This was referenced Feb 12, 2026
pshriwise
approved these changes
Feb 13, 2026
pshriwise
left a comment
Owner
There was a problem hiding this comment.
This looks good! Thank you for the update @matthewfeickert 👍🏻
Contributor
Author
|
Thanks for the fast review and merge, @pshriwise. Can I also have you look at conda-forge/staged-recipes#32181 (which motivated this PR)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant for:
Example Pixi manifest that will build the project using the state of this PR:
$ pixi run build