Add the ability to create dust with non-isotopic scattering phase functions#11
Open
psheehan wants to merge 17 commits into
Open
Add the ability to create dust with non-isotopic scattering phase functions#11psheehan wants to merge 17 commits into
psheehan wants to merge 17 commits into
Conversation
- Adding a new `IsotropicDust`, `HenyeyGreensteinDust`, and `GeneralDust` classes to handle different types of dust scattering. - Move functionality to update opactities for photons/the grid to the *Dust clases so they can each provide the relevant info. - Pass the camera orientation through the raytracing process to calculate the relevant scattering angles.
…arious combinations of possible inputs.
…ds another place where we need to make sure arctanh(ksi) does not go infinite.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 90.12% 88.67% -1.46%
==========================================
Files 11 11
Lines 2360 2719 +359
==========================================
+ Hits 2127 2411 +284
- Misses 233 308 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
psheehan
force-pushed
the
add_non_isotropic_dust
branch
from
afbe3a2 to
2cd3dac
Compare
…urning on/off checkpointing, including setting the pickle protocol; add trained HenyeyGreenstein dust model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new types of dust,
HenyeyGreensteinDustthat uses the Henyey-Greenstein scattering phase functions, andGeneralDustthat can be supplied with a user-defined scattering phase function. Additionally,Dustis now a base class that contains all common dust functionality, andIsotropicDusthas been created to handle the case of dust with an isotropic scattering phase function.This PR includes updates not only to create such dust classes, but also to be able to use them within models. As a part of this, code to set grid opacities, etc. was moved over to the dust classes as each dust class should know what needs to be added.