fix doc: correct models.Response.json() docstring #6529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupam-arista
changed the title
|
I know I'm not an admin, but this doc string change is a solid change could it be merged? |
anupam-arista
changed the title
anupam-arista
changed the title
anupam-arista
changed the title
Contributor
Author
|
I had spent like 1 hour because these 2 words were pointing the wrong way, so maintainers please consider this nit. |
anupam-arista
changed the title
sigmavirus24
requested changes
Feb 11, 2025
Co-authored-by: Ian Stapleton Cordasco <[email protected]>
Contributor
sigmavirus24
left a comment
sigmavirus24
left a comment
There was a problem hiding this comment.
I think my last suggestion forgot a new line
Co-authored-by: Ian Stapleton Cordasco <[email protected]>
sigmavirus24
approved these changes
Feb 12, 2025
nateprewitt
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is doing json-decode of a response content(if any) to a python object, unlike what the docstring says..