Skip to content

chore: adjust storage key to clear prior years favorites #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: adjust storage key to clear prior years favorites #91

wants to merge 2 commits into from

Conversation

JacobCoffee
Copy link
Member

Resolves #66

@JacobCoffee JacobCoffee requested a review from ewdurbin March 13, 2025 21:55
@JacobCoffee JacobCoffee mentioned this pull request Mar 13, 2025
Merged
@JacobCoffee
Copy link
Member Author

JacobCoffee commented Mar 13, 2025 •
edited
Loading

Extremely not blocking, but this makes me think: What if we add a "key_prefix" variable in the configuration that we applied to all the keys we have in storage to make this a one-time change each year that negates all state from previous years 💭

#92

ewdurbin added a commit that referenced this pull request Mar 19, 2025
@ewdurbin
use named ionic storage
f034d08 
Closes #66

Supersedes #91
Supersedes #92
@ewdurbin ewdurbin mentioned this pull request Mar 19, 2025
Merged
@JacobCoffee
Copy link
Member Author

#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin Awaiting requested review from ewdurbin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JacobCoffee