Rerun benchmark with CypherEngine in lance-graph - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version of lance-graph uses the execute API, which rebuildt the catalog each time it was called (since the dataset was passed as an input parameter). In v0.5.1, lance-graph introduces a new CypherEngine API (see lance-format/lance-graph#124), which caches the catalog, so we can compare the pure query execution times with other engines in the benchmark repo.
This PR updated the benchmark results accordingly, and displays the results via a heatmap. The performance due to reusing the catalog is significantly better than before!