Conversation
Comment on lines
+220
to
+222
| # Export plain keywords for later PR body + workflow summary steps | ||
| KEYWORDS="$KEYWORDS_PATTERN" | ||
| echo "KEYWORDS=$KEYWORDS" >> "$GITHUB_ENV" |
Contributor
There was a problem hiding this comment.
KEYWORDS is rendered directly into the step-summary markdown table as-is (| Keywords | $KEYWORDS |), so the | alternation breaks the table; should we export a plain-text value for display or rename to KEYWORDS_PATTERN and transform before rendering?
Finding type: Logical Bugs | Severity: 🟢 Low
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
`.github/workflows/poll-nvd-cves.yml` around lines 220-222 inside the `Merge and filter
CVEs` step, `KEYWORDS` is set to `KEYWORDS_PATTERN` (a regex alternation) and then later
interpolated into a markdown table where `|` is treated as a column separator, producing
a malformed summary. Refactor so the env used for human-facing output contains a
markdown-safe plain-text representation (e.g., a joined keyword list with `|`
escaped/removed), while keeping the regex value for jq filtering as-is. Concretely,
rename the current env export to something like `KEYWORDS_PATTERN` (or keep it internal)
and introduce/export a separate `KEYWORDS_DISPLAY` (plain keywords) for the summary
rendering.
Contributor
There was a problem hiding this comment.
Commit 00d2a0e addressed this comment by exporting a new KEYWORDS value derived from nvd_summary_keywords (a plain-text list) while keeping the regex pattern only for filtering, so the workflow summary now renders markdown-safe keywords instead of the alternation string that broke the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Motivation
hermes-agentproject alongside existing targets and make the plain keyword list available for PR bodies and workflow summaries.Description
KEYWORDSexport in the poll workflow by writingKEYWORDS=$KEYWORDS_PATTERNto theGITHUB_ENVso downstream steps can access the plain keywords.hermes-agentto the NVD query specs innvd_query_specs()and to the keyword pattern returned bynvd_keyword_pattern()inscripts/feed-utils.sh.nvd_github_ref_pattern()to includegithub.com/nousresearch/hermes-agentso GitHub reference matching detects that repository.github.com/nousresearch/hermes-agentand the tokenhermes-agentin the inferred targets checks (changes appear in both detection blocks).Testing
Codex Task
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enable the poll workflow and
feed-utilshelper functions to treathermes-agentlike other monitored projects so NVD detection, inferred targets, and keyword specs include the new repo, keywords, and CPE references. Exportnvd_summary_keywordsintoGITHUB_ENVso downstream PR body and workflow summary steps can reuse the concise keyword list.nvd_summary_keywordsintoGITHUB_ENVso downstream steps can reuse the concise keyword list for PR bodies and workflow summaries.Modified files (1)
Latest Contributors(2)
hermes-agentkeywords, GitHub ref, and CPE patterns so the poll workflow andfeed-utilsinferred-target logic normalize the new repo alongside other monitored projects.Modified files (2)
Latest Contributors(2)