Open
Conversation
Closes: prometheus#687 Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
Author
|
@beorn7 This is still using the up/down caret icons from the bootstrap4-glyphicons set. I wasn't sure if we also want to replace them with something modern. We could possibly ditch them altogether if we use the accordion component, which seems to have its own up/down caret toggle icons. Also, we're still depending on jQuery for the XHR stuff and a bit of DOM manipulation in |
Member
|
I don't have strong feelings here. But this should be reviewed/decided by the new maintainers @jan--f and @machine424 . |
Member
|
And thanks for doing this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated Bootstrap v4 library with v5.
Closes: #687