WIP: Initial support for CEL#267
Open
mrueg wants to merge 1 commit intoprometheus-community:masterfrom
Open
Conversation
Member
Author
|
@SuperQ @rustycl0ck any thoughts on this? Would love to get some early feedback to see if this is something you'd be interested in adding. |
|
Thanks a lot for this MR, just tested this branch and it seems to work fine. We used: This should potentially solve a lot of related issues that need a bit more advance logic, such as: Please add a bit of documentation, then it would be perfect 🚀 |
Member
Author
|
@sbor23 thanks for testing it! I still need to figure out a couple of things here, I have updated the original messages |
75a0c7e to
72ab3d8
Compare
Member
Author
|
I went ahead with the engine field solution |
5a26a4a to
bdc4eb9
Compare
d0c9753 to
5f61823
Compare
e4fa7aa to
d4ad336
Compare
This adds initial support for queries using the common expression language (CEL). ValueToJSON function is adapted from https://github.com/google/cel-go/blob/cfbf821f1b458533051306305a39b743db7c4bdb/codelab/codelab.go#L274 (Apache-2.0 Licensed) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
@mrueg any reason this still has WIP in the title? Any chance it can be reviewed and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial support for queries using the common expression language (CEL).
having additional separate fields
vs. defining an engine for the query
See: #263