-
Notifications
You must be signed in to change notification settings - Fork 142
chore: contrib: better packaging support #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixes #264 |
Import our internal CI spec for build ipmi_exporter. Currently depend on internet Signed-off-by: Konstantin Shalygin <[email protected]>
|
@bitfehler is there any interest to merge this? |
|
Not sure, to be honest. This all looks a bit messy, and I am somewhat getting the impression that all this packaging stuff should be removed entirely from the repo. If I understand correctly, the .spec file is using only files from the Arch Linux (!?) package? So why bother adding the systemd and sudoers file in here? Doesn't the RPM ecosystem have something like the AUR or whatnot where package definitions can be added with a low barrier to entry? Maybe this EPEL thing or such? (I have never used a RPM-based distro in my life, so no idea what it really is) |
|
As I said before:
So the steps is:
Then I go to the Archlinux and make MR that will use shipped with tarball systemd files |
|
Ok, then it would make a bit more sense at least, but:
Will they even do that? Is there an example package that uses upstream-supplied systemd files? I find those are pretty heavy with distribution-specific concerns, and I would suspect they would like to exert a certain amount of control over those? I might be wrong, but that would be my gut feeling... |
The main issue, is that upstreams provided bad systemd files or not provided files at all. Okay, let's try to answer in another way - what exactly I do for Promethes community: Better work with DNS for alertmanager#2 & prometheus#1 As you can see, it is not so difficult to make high-quality sytemd service files that will work without the distro specific, if there is an opportunity to test them on production. And it is damn difficult to communicate with each project separately, in at least 50% of cases the contributor does not receive any response at all And answering your question directly - yes, in Arch it is aimed at using files from the project. A specific example oauth2-proxy/oauth2-proxy#2655 lately package maintainer use this fixes in PKGBUILD |
|
Last up |
|
I inquired with the team, and the official stance is that the source of truth for "how to run stuff" should be [prometheus-community][https://github.com/prometheus-community/ansible]. Patches to the templates in there (see e.g. As such, I am closing this and will also remove the existing packaging stuff in |
|
Thanks for your position, that makes more sense! I'll bring my snippets to Arch. Also, #264 should be closed |
Import our internal CI spec for build
ipmi_exporter. Currently depend on internet