Don't log collector errors #1050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid logging collector failures at Error level to avoid log spam. Signed-off-by: SuperQ <[email protected]>
sysadmind
reviewed
Jun 12, 2025
| @@ -185,7 +185,7 @@ func execute(ctx context.Context, name string, c Collector, ch chan<- prometheus | |||
| if IsNoDataError(err) { | |||
| logger.Debug("collector returned no data", "name", name, "duration_seconds", duration.Seconds(), "err", err) | |||
| } else { | |||
| logger.Error("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err) | |||
| logger.Debug("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err) | |||
There was a problem hiding this comment.
I think Error is the right level here. It really is an error.
There was a problem hiding this comment.
No, it's not normal for collectors to error, we have success metrics to let users know that individual collectors fail.
We don't want scrapes to generate logs.
There was a problem hiding this comment.
Users often go to the logs when things aren't working as expected. We have metrics that say was successful or failed, but that doesn't tell you the why. That's what the logs are for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid logging collector failures at Error level to avoid log spam.