Skip to content

propshaft updates#2029

Closed
dczulada wants to merge 33 commits intomasterfrom
propshaft_single_commit
Closed

propshaft updates#2029
dczulada wants to merge 33 commits intomasterfrom
propshaft_single_commit

Conversation

@dczulada
Copy link
Copy Markdown
Contributor

favorite and downloads

a few more

clear out application css

no turbo on product form

allow for page to reload prior to checking database

mpl download

more inits

also include the duplicate change

Additional propshaft transition work

Additional propshaft transition work 2

Fix checklist tests, add controllers, update html.erb embedded javascript

Additional controllers, attempt to create DataTable controller

Almost all cucumber tests working, trouble with autocomplete and datatables controllers

this works?

fix no entry

update cucumber test

get unit tests to run successfully

Remove public/assets test execution files, add folder to .gitignore

Remove byebugs, add multi-upload changes

A few fixes

Data frame for filtering tasks, more cucumber passes but still some failures

some small changes

some other changes

more

rubocop fixes

test execution test updates

use turbostream for updates

generic controller

use turbostream for multi_upload

filtering test

vendor upload

program fields

patient analysis tracker

mpl download

execution results controller

execution download

checklist refresh

bulk download

application status

add POC as a controller

refresh test execution after validations finish

fix users table

disable turbo for set default

fix up vendor preferences

reload pages for filtering test creation

make rubocop happy

popup controller

eslint update

move vendor files

hardtabs too

javascript, not javascripts

new eslint config

update config

turn off no-invalid-this

get popovers working

navigate errors

url for splash page image

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 87.17949% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.02%. Comparing base (5f31e0f) to head (68fcd7c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
app/controllers/products_controller.rb 62.50% 3 Missing ⚠️
app/controllers/checklist_tests_controller.rb 71.42% 2 Missing ⚠️
app/controllers/program_tests_controller.rb 71.42% 2 Missing ⚠️
app/controllers/vendors_controller.rb 0.00% 2 Missing ⚠️
app/helpers/assets_helper.rb 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   95.96%   92.02%   -3.95%     
==========================================
  Files         158      159       +1     
  Lines        7169     7231      +62     
==========================================
- Hits         6880     6654     -226     
- Misses        289      577     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dczulada dczulada force-pushed the propshaft_single_commit branch from 68ab340 to 3084e23 Compare March 31, 2026 18:04
dczulada added 28 commits April 6, 2026 15:46
favorite and downloads

a few more

clear out application css

no turbo on product form

allow for page to reload prior to checking database

mpl download

more inits

also include the duplicate change

Additional propshaft transition work

Additional propshaft transition work 2

Fix checklist tests, add controllers, update html.erb embedded javascript

Additional controllers, attempt to create DataTable controller

Almost all cucumber tests working, trouble with autocomplete and datatables controllers

this works?

fix no entry

update cucumber test

get unit tests to run successfully

Remove public/assets test execution files, add folder to .gitignore

Remove byebugs, add multi-upload changes

A few fixes

Data frame for filtering tasks, more cucumber passes but still some failures

some small changes

some other changes

more

rubocop fixes

test execution test updates

use turbostream for updates

generic controller

use turbostream for multi_upload

filtering test

vendor upload

program fields

patient analysis tracker

mpl download

execution results controller

execution download

checklist refresh

bulk download

application status

add POC as a controller

refresh test execution after validations finish

fix users table

disable turbo for set default

fix up vendor preferences

reload pages for filtering test creation

make rubocop happy

popup controller

eslint update

move vendor files

hardtabs too

javascript, not javascripts

new eslint config

update config

turn off no-invalid-this

get popovers working

navigate errors

url for splash page image
poc update

navigation updates

bring in parsley

close modal after code selection

toggle scss updates

upload

more upload

cucumber test cleanup

use .min files

silence warning from mustache

use turbo: false
@dczulada dczulada force-pushed the propshaft_single_commit branch from abceb05 to c8a192b Compare April 6, 2026 19:47
dczulada and others added 2 commits April 7, 2026 16:28
* Looks bad but might be working?

* Ensure formatting remains the same
@dczulada dczulada closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants