Skip to content

CVU's Cat3PopulationValidator needs to account for bundle specific ge…#2010

Merged
dczulada merged 3 commits intomasterfrom
gender_code_cvu
Apr 10, 2026
Merged

CVU's Cat3PopulationValidator needs to account for bundle specific ge…#2010
dczulada merged 3 commits intomasterfrom
gender_code_cvu

Conversation

@dczulada
Copy link
Copy Markdown
Contributor

@dczulada dczulada commented Jan 5, 2026

…nder codes

https://oncprojectracking.healthit.gov/support/browse/CYPRESS-2820

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.01%. Comparing base (61b1e40) to head (66bc7c8).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   95.94%   96.01%   +0.07%     
==========================================
  Files         158      158              
  Lines        7169     7170       +1     
==========================================
+ Hits         6878     6884       +6     
+ Misses        291      286       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One older typo I noticed :)

Comment thread lib/validators/cat3_population_validator.rb Outdated
@dczulada dczulada requested a review from elsaperelli April 8, 2026 16:26
Copy link
Copy Markdown
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dczulada dczulada merged commit bf3371c into master Apr 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants