feat(config): administrators get delete privileges for tenant namespaces #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
26
to
28
| return !reflect.DeepEqual(oldObj.Spec, newObj.Spec) | ||
| // or with k8s helpers: | ||
| // return !equality.Semantic.DeepEqual(oldObj.Spec, newObj.Spec) |
Member
There was a problem hiding this comment.
We should avoid at our best the usage of the reflection package since it's expensive.
Collaborator
Author
There was a problem hiding this comment.
removed refelction for primitive check
Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
force-pushed
the
feat/admin-delete
branch
from
75ad204 to
73633d1
Compare
prometherion
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.