hv: pm: fix acpi register size calculation #8772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Access Size field in ACPI GAS was not introduced before ACPI 2.0, Errata C. It is not guaranteed to be a non zero value, like QEMU programs it to 0. As it only indicates how many bytes it can be accessed at once, the register size should be determined by Bit Width and Bit Offset. In IO space, Bit Offset is always 0, the size is (Bit Width / 8). Tracked-On: projectacrn#8771 Signed-off-by: Jiaqing Zhao <[email protected]> Reviewed-by: Li Fei <[email protected]>
jiaqingz-intel
requested review from
dongyaozu,
lifeix and
junjiemao1
as code owners
|
start to run premerge test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Access Size field in ACPI GAS was not introduced before ACPI 2.0, Errata C. It is not guaranteed to be a non zero value, like QEMU programs it to 0. As it only indicates how many bytes it can be accessed at once, the register size should be determined by Bit Width and Bit Offset. In IO space, Bit Offset is always 0, the size is (Bit Width / 8).
Tracked-On: #8771
Reviewed-by: Li Fei [email protected]