Update compiler flags for homebrew packages on Apple silicon #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add /opt/homebrew/{include,lib} flags for apple silicon macs, which are not included as default search paths by Clang/GCC. (Homebrew uses /usr/local/{include,lib} on intel macs)
sjaeckel
approved these changes
Oct 25, 2025
On macOS running ./configure --enable-omemo was failing to find gcrypt despite being installed.
sjaeckel
approved these changes
Oct 26, 2025
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the PR. @jubalh is sick unfortunately and I don't know when he will be back, so this could take some time to be merged.
Not sure if you have the time & patience, but maybe you want to add CI for Mac?
If you go for it I'd recommend https://github.com/nektos/act for developing that, which should also work on Mac as of their docs.
Contributor
Author
|
I'll definitely look into it! |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add /opt/homebrew/{include,lib} flags for apple silicon Macs.
Homebrew moved from /usr/local to /opt/homebrew for Apple silicon Macs, but /opt/homebrew/{include,lib} are not included as default search paths by Clang/GCC.
As a result, without adding these paths, running 'make' fails with errors complaining that <gcrypt.h>, <signal/key_helper.h> etc cannot be found.
UPDATE:
Use PKG_CHECK_MODULES to check for libgcrypt: previously
./configure --enable-omemoresulted indespite libgcrypt being installed.