Skip to content

fix: pass geometry to freeGeometry in CPU transform benchmark - #9071

Merged
davepagurek merged 2 commits into
processing:mainfrom
Danyccsf:fix/freegeometry-benchmark-cleanup
Aug 11, 2026
Merged

fix: pass geometry to freeGeometry in CPU transform benchmark#9071
davepagurek merged 2 commits into
processing:mainfrom
Danyccsf:fix/freegeometry-benchmark-cleanup

Conversation

@Danyccsf

Copy link
Copy Markdown
Contributor

Summary

Fixes #9041.

This PR corrects an incorrect cleanup call in the CPU-transform benchmark.

Details

test/bench/cpu_transforms.bench.js passed the myp5.model function reference to freeGeometry() instead of the geometry instance created during the run. This emitted an FES “Expected Geometry” validation message even though the benchmark completed.

The cleanup call now passes shape, the generated geometry instance.

Validation

  • Ran npx vitest bench test/bench/cpu_transforms.bench.js.
    • Chromium WebGL and WebGPU benchmark contexts passed.
    • The prior Expected Geometry FES message no longer appeared.
  • Ran npm test: 2,251 tests passed with 0 failures; 12 skipped and 216 todo.
  • Ran npm run lint successfully with 0 errors.

AI usage

I used Codex/ChatGPT for assistive debugging and workflow guidance. I reviewed the change, implemented it, and ran the local validation myself.

@welcome

welcome Bot commented Aug 11, 2026

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@p5-bot

p5-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: 81d9ca6

Previous deployments

5be550c


This is an automated message.

@davepagurek davepagurek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good!

@davepagurek
davepagurek merged commit 77b753d into processing:main Aug 11, 2026
6 checks passed
@davepagurek

Copy link
Copy Markdown
Contributor

@all-contributors please add @Danyccsf for test

@allcontributors

Copy link
Copy Markdown
Contributor

@davepagurek

I've put up a pull request to add @Danyccsf! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[p5.js 2.0+ Bug Report]: Benchmark cleanup passes p5.model to freeGeometry

2 participants