fix: pass geometry to freeGeometry in CPU transform benchmark - #9071
Merged
davepagurek merged 2 commits intoAug 11, 2026
Merged
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
davepagurek
approved these changes
Aug 11, 2026
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update, looks good!
Contributor
|
@all-contributors please add @Danyccsf for test |
Contributor
|
I've put up a pull request to add @Danyccsf! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9041.
This PR corrects an incorrect cleanup call in the CPU-transform benchmark.
Details
test/bench/cpu_transforms.bench.jspassed themyp5.modelfunction reference tofreeGeometry()instead of the geometry instance created during the run. This emitted an FES “Expected Geometry” validation message even though the benchmark completed.The cleanup call now passes
shape, the generated geometry instance.Validation
npx vitest bench test/bench/cpu_transforms.bench.js.Expected GeometryFES message no longer appeared.npm test: 2,251 tests passed with 0 failures; 12 skipped and 216 todo.npm run lintsuccessfully with 0 errors.AI usage
I used Codex/ChatGPT for assistive debugging and workflow guidance. I reviewed the change, implemented it, and ran the local validation myself.