Skip to content

Fix async validation errors persist when unrelated fields are edited #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Subham-KRLX
Copy link

Fixes #3536

Changes:
Removed validateFields prop from username and email fields in SignupForm.jsx to ensure async validation errors persist when other fields change.

Updated validateSignup function in reduxFormUtils.js to merge existing async errors with synchronous validations to prevent overwriting error messages prematurely.

Verified that username and email validation errors no longer disappear when editing unrelated fields such as password or confirmPassword.

Tested locally with multiple validation scenarios; all errors behave as expected.
Ensured change complies with existing linting and testing standards.

Checklist:
has no linting errors (npm run lint)
has no test errors (npm run test)
is from a uniquely-named feature branch and is up to date with the develop branch
is descriptively named and links to an issue number, i.e. Fixes #123

@yugalkaushik
Copy link
Contributor

@Subham-KRLX The issue is already being addressed by the original author through a pull request. Please ask to be assigned before working on any issue, as we avoid concurrent work. You can instead pick an issue labeled with the help wanted tag.

@Subham-KRLX
Copy link
Author

Thank you for the clarification I apologize for the overlap I will make sure to request assignment before starting on any issue in the future I will look for help wanted issues to contribute to going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async validation errors disappear when unrelated fields are edited text editor + canvas sometimes don't load on Safari
2 participants