Skip to content

Use reparameterize=false for extract_kernel and decompose (fix #33) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fsaad merged 1 commit into from
Oct 24, 2025
Merged

Use reparameterize=false for extract_kernel and decompose (fix #33) #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ series structures that make up each particle of `model`.
[Time Series Decomposition Tutorial](./tutorials/decomposition.html)
"""
function decompose(model::GPModel)
kernels = covariance_kernels(model)
kernels = covariance_kernels(model; reparameterize=false)
unrolled = map(GP.unroll, kernels)
@assert length(kernels) == num_particles(model)
models = Vector{GPModel}(undef, length(kernels))
Expand Down Expand Up @@ -785,7 +785,7 @@ retained.
- [`AutoGP.GP.extract_kernel`](@ref)
"""
function extract_kernel(model::GPModel, t::Type{T}; retain::Bool=true) where T <: GP.LeafNode
kernels = covariance_kernels(model)
kernels = covariance_kernels(model; reparameterize=false)
new_kernels = [GP.extract_kernel(kernel, t; retain=retain) for kernel in kernels]
# TODO: Should we use zero noise or current noise?
new_model = GPModel(
Expand Down