feat(skore-hub-backend): add TOML ConfigMap for readable configuration - #13
Draft
jerome-probabl wants to merge 1 commit into
Draft
feat(skore-hub-backend): add TOML ConfigMap for readable configuration#13jerome-probabl wants to merge 1 commit into
jerome-probabl wants to merge 1 commit into
Conversation
jerome-probabl
force-pushed
the
feat/skore-hub-backend-configmap
branch
from
August 4, 2026 08:34
4e590b5 to
a39cc7f
Compare
Add an optional ConfigMap that mounts a TOML config file (skh.config) and injects SKH_CONFIG_FILE into both the Deployment and migrations Job. TOML takes priority over SKH__* env vars, so secrets remain in extraEnv/envSecret while non-sensitive settings move to a readable, config.sample.toml-style file. A checksum pod annotation rolls out pods and re-runs migrations on config change. Disabled by default; existing env-var-only behavior is unchanged. The migrations Job also gains the .Values.volumes/.Values.volumeMounts passthrough the Deployment already had, so mounts the job needs (e.g. the PostgreSQL CA certificate) are no longer dropped. Bump the chart to 0.1.10 (0.1.9 on main) as ct lint requires a version increment, and link values.example.yaml by repository URL: a relative path escaping docs_dir fails `mkdocs build --strict`.
jerome-probabl
force-pushed
the
feat/skore-hub-backend-configmap
branch
from
August 5, 2026 15:56
a39cc7f to
2847c91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional ConfigMap that mounts a TOML config file (skh.config) and injects SKH_CONFIG_FILE into both the Deployment and migrations Job. TOML takes priority over SKH__* env vars, so secrets remain in extraEnv/envSecret while non-sensitive settings move to a readable, config.sample.toml-style file. A checksum pod annotation rolls out pods and re-runs migrations on config change. Disabled by default; existing env-var-only behavior is unchanged.