refactor(postgres): schema-node tree restructure — database→namespace→table→policy diff tree

[wmadden-electric]

What this delivers

Retires the conflated PostgresSchemaIR (a diff-tree node, a Postgres schema, and the tree root at once) for a single-purpose database → namespace → table → policy schema-node tree, and — through three rounds of review — restructures schema diffing and db verify/plan around it. Foundation for slice 3 (@@rls, managed/external grading, policy rename).

The architecture (as landed)

Authoritative design: design-diff-and-verify.md. Four actors, cleanly separated:

interface SchemaDiffer { diff(contract, actual): SchemaDiff }     // SPI on the target

class SchemaDiff<TNode extends DiffableNode = DiffableNode> {     // the differ's whole result
  readonly issues: readonly SchemaIssue[]                         // legacy relational differ
  readonly schemaDiffIssues: readonly SchemaDiffIssue<TNode>[]    // generic node differ — carries its node
  filter(keep: (issue) => boolean): SchemaDiff<TNode>
}

• The differ is dumb — one contract + the actual schema in, node-typed issues out (Postgres: SchemaDiff<SqlSchemaDiffNode>; the planner builds ops from the typed nodes, no casts). Internals private.
• The contract-space aggregate is passive data — it answers ownership (declaresEntity / declaringSpaces); it diffs, verifies, and classifies nothing.
• The orchestration owns the verbs — it runs the differ per contract space and drives both consumers.
• Verify presents two distinct pieces of information: (1) per contract space, is the contract satisfied — the space's declared elements, pass/fail by missing/mismatch; (2) which live schema elements are unclaimed by any contract — a standalone list, reported once. An unclaimed element is never forced into a contract's structure (and is no longer duplicated once per space). Strict fails on unclaimed; lenient reports it.
• The planner interprets nothing about spaces — the orchestration injects a blind keepDiffIssue predicate (built over the passive aggregate); the planner applies it verbatim before op-building. No schema pruning, no "other spaces' names", no post-scoping — scope-schema-result, entitiesOwnedByOtherSpaces, and the set-subtraction helper are deleted.
• Node typology: five …SchemaNode classes with defined nodeKinds; static is/assert guards (no instanceof, no node-constructing ensure()); isEqualTo is identity; the vocabulary is contract space throughout the aggregate.

Review response

• Round 1 (17 comments): the diff became a required target-descriptor operation; relational diffing relocated out of the verify module; nodeKind guards.
• Round 2 (~45 comments, units V1–V5): SchemaDiffer SPI + SchemaDiff result; node-guard consistency; file dedup (one diff module; diff-SPI types out of the catch-all types.ts); planner cleanups; transient IDs removed.
• Round 3 (12 comments, units R1–R4): node-typed issues (5e3673318); the two-part verify (9e2e80f0f + 8c3d4a10b + 9309fd00d); the plan collapse deleting the cross-space plumbing (14f5b7a73); the contract-space rename retiring "member" and "schema result" (9d56e8eba).

Confirmed non-duplicates from review: contract-to-postgres-database-schema-node builds the Postgres tree atop the shared per-namespace table conversion (contractToSchemaIR's flat map is SQLite-only); verify-postgres-namespaces is live (its missing_schema issues drive multi-schema CREATE SCHEMA planning).

Verification

Planner ops byte-identical throughout (fixtures:check clean at every unit); contract infer unchanged; the runner's post-apply verify and single-space family verify preserved; multi-space guards green (cross-namespace-fk, supabase classification.e2e + cross-contract-fk, multi-namespace-runtime). lint:deps clean; lint:casts net −11. The deliberate output change is confined to db verify's unclaimed-element reporting (two-part model above). CI on the merge ref arbitrates the full suites.

Follow-ons (out of scope)

• Relational port — merge the two issue types into one node-typed generic differ; settles SchemaIssue node-typing and lifts root/counts off the relational walk.
• Multi-namespace verify-tree shaping — the family verify retains only the first namespace's tree while counts sum all namespaces (pre-existing).
• TML-2958 — PSL-inference tree-walk.
• TML-2936 — full annotations.pg retirement.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added richer database schema verification with per-space results and a new “unclaimed elements” report.
  • PostgreSQL and SQLite introspection now use structured schema trees, improving visibility into namespaces, tables, policies, roles, and indexes.
  • Added PostgreSQL PSL inference support and new public schema-diff utilities.

• Bug Fixes

  • Improved handling of cross-space database objects to avoid false drop/extra findings.
  • Updated migration planning and verification to better handle multi-space projects and namespaced schemas.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This large PR replaces the flat Postgres schema IR (PostgresSchemaIR/PostgresTableIR) with a tree of schema-diff nodes (PostgresDatabaseSchemaNode → namespace → table → policy/role), introduces SqlSchemaIRNode-based SQL family diff/verify APIs (diffDatabaseSchema, verifySqlSchemaTree), and reworks Postgres planner/runner/adapter/PSL-inference around it. Mongo and SQLite gain family-specific diff/verify scoping callbacks replacing schema pre-projection. Separately, the migration-tools aggregate renames ContractSpaceMember to AggregateContractSpace, rewrites the verifier to run full-schema per-space checks with new "unclaimed elements" tracking, and propagates this through CLI commands and formatters.

Changes

Postgres schema IR tree and family diff/verify

Layer / File(s)	Summary
New Postgres schema node classes packages/3-targets/3-targets/postgres/src/core/schema-ir/*, postgres-rls-policy.ts, postgres-role.ts, tests	Adds database/namespace/table/policy/role schema-diff node classes and schema-node-kinds discriminants; PostgresRlsPolicy/PostgresRole become plain Contract-IR entities.
SQL family API + generic diff types packages/2-sql/9-family/src/core/*, packages/1-framework/1-core/framework-components/src/control/schema-diff.ts, control-migration-types.ts	Introduces SqlSchemaIRNode-based introspect/verifySchema, diffDatabaseSchema, verifySqlSchemaTree, StorageTable.is/assert, and generic SchemaDiffIssue<TNode>/DiffIssue<TNode>/SchemaDiff<TNode>.
Contract-to-node conversion & combined diff contract-to-postgres-database-schema-node.ts, diff-database-schema.ts, diff-postgres-schema.ts, resolve-ddl-schema.ts	Adds contractToPostgresDatabaseSchemaNode and diffPostgresDatabaseSchema, combining relational and RLS policy diffs.
Planner/runner rewrite postgres/src/core/migrations/planner.ts, runner.ts, pgvector/adapter tests	planSql computes one combined diff; runner uses family.introspect + family.verifySchema.
PostgresControlAdapter introspect 6-adapters/postgres/src/core/control-adapter.ts, tests	Introspect returns a PostgresDatabaseSchemaNode; collectSchemaDiffIssues replaced by diffDatabaseSchema.
PSL inference entry point psl-infer/infer-psl-contract.ts, exports/psl-infer.ts	inferPostgresPslContract consumes the schema tree directly; new psl-infer package export.
Mongo/SQLite scoping callbacks mongo-target/.../scope-verify-result.ts, control-target.ts, sqlite/.../diff-database-schema.ts	Replaces pre-projection with post-verify result scoping (scopeVerifyResultToSpace, diffSqliteDatabaseSchema).

AggregateContractSpace rename and unclaimed elements

Layer / File(s)	Summary
Aggregate rename + verifier rewrite migration/src/aggregate/*, unclaimed-elements.ts, tests	Renames ContractSpaceMember→AggregateContractSpace; verifier now verifies full schema per space and computes unclaimed via stripExtraFindings/collectExtraElementNames.
CLI consumption cli/src/commands/*, control-api/operations/*, utils/*, tests	CLI commands, combineVerifyResults, and formatters surface per-space results plus unclaimed elements.

Estimated code review effort: 5 (Critical) | ~150 minutes

Sequence Diagram(s)

sequenceDiagram
  participant verifyMigration
  participant verifySchemaForSpace
  participant stripExtraFindings
  participant collectExtraElementNames
  verifyMigration->>verifySchemaForSpace: verify(schemaIntrospection, space, mode)
  verifySchemaForSpace-->>verifyMigration: VerifyDatabaseSchemaResult
  verifyMigration->>stripExtraFindings: strip per-space extras
  stripExtraFindings-->>verifyMigration: schemaPerSpace entry
  verifyMigration->>collectExtraElementNames: gather extra names across spaces
  collectExtraElementNames-->>verifyMigration: unclaimed names

Loading

Possibly related PRs

• prisma/prisma-next#494: Both PRs change the contract-space per-space schema projection logic around projectSchemaToSpace.
• prisma/prisma-next#629: Both PRs modify the migration aggregate's per-space ownership/entity-name derivation path affecting verifier.ts.
• prisma/prisma-next#868: Main PR's unclaimed-elements logic derives "unclaimed" from schemaDiffIssues with outcome === 'extra', matching this PR's diffSchemas/ownership filtering flow.

Suggested reviewers: wmadden

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 44.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the Postgres schema-node tree refactor and the new database→namespace→table→policy diff structure.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch slice/schema-node-tree-restructure

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

@prisma-next/extension-author-tools

npm i https://pkg.pr.new/@prisma-next/extension-author-tools@894

@prisma-next/mongo-runtime

npm i https://pkg.pr.new/@prisma-next/mongo-runtime@894

@prisma-next/family-mongo

npm i https://pkg.pr.new/@prisma-next/family-mongo@894

@prisma-next/sql-runtime

npm i https://pkg.pr.new/@prisma-next/sql-runtime@894

@prisma-next/family-sql

npm i https://pkg.pr.new/@prisma-next/family-sql@894

@prisma-next/extension-arktype-json

npm i https://pkg.pr.new/@prisma-next/extension-arktype-json@894

@prisma-next/middleware-cache

npm i https://pkg.pr.new/@prisma-next/middleware-cache@894

@prisma-next/mongo

npm i https://pkg.pr.new/@prisma-next/mongo@894

@prisma-next/extension-paradedb

npm i https://pkg.pr.new/@prisma-next/extension-paradedb@894

@prisma-next/extension-pgvector

npm i https://pkg.pr.new/@prisma-next/extension-pgvector@894

@prisma-next/extension-postgis

npm i https://pkg.pr.new/@prisma-next/extension-postgis@894

@prisma-next/postgres

npm i https://pkg.pr.new/@prisma-next/postgres@894

@prisma-next/sql-orm-client

npm i https://pkg.pr.new/@prisma-next/sql-orm-client@894

@prisma-next/sqlite

npm i https://pkg.pr.new/@prisma-next/sqlite@894

@prisma-next/extension-supabase

npm i https://pkg.pr.new/@prisma-next/extension-supabase@894

@prisma-next/target-mongo

npm i https://pkg.pr.new/@prisma-next/target-mongo@894

@prisma-next/adapter-mongo

npm i https://pkg.pr.new/@prisma-next/adapter-mongo@894

@prisma-next/driver-mongo

npm i https://pkg.pr.new/@prisma-next/driver-mongo@894

@prisma-next/contract

npm i https://pkg.pr.new/@prisma-next/contract@894

@prisma-next/utils

npm i https://pkg.pr.new/@prisma-next/utils@894

@prisma-next/config

npm i https://pkg.pr.new/@prisma-next/config@894

@prisma-next/errors

npm i https://pkg.pr.new/@prisma-next/errors@894

@prisma-next/framework-components

npm i https://pkg.pr.new/@prisma-next/framework-components@894

@prisma-next/operations

npm i https://pkg.pr.new/@prisma-next/operations@894

@prisma-next/ts-render

npm i https://pkg.pr.new/@prisma-next/ts-render@894

@prisma-next/contract-authoring

npm i https://pkg.pr.new/@prisma-next/contract-authoring@894

@prisma-next/ids

npm i https://pkg.pr.new/@prisma-next/ids@894

@prisma-next/psl-parser

npm i https://pkg.pr.new/@prisma-next/psl-parser@894

@prisma-next/psl-printer

npm i https://pkg.pr.new/@prisma-next/psl-printer@894

@prisma-next/cli

npm i https://pkg.pr.new/@prisma-next/cli@894

@prisma-next/cli-telemetry

npm i https://pkg.pr.new/@prisma-next/cli-telemetry@894

@prisma-next/config-loader

npm i https://pkg.pr.new/@prisma-next/config-loader@894

@prisma-next/emitter

npm i https://pkg.pr.new/@prisma-next/emitter@894

@prisma-next/language-server

npm i https://pkg.pr.new/@prisma-next/language-server@894

@prisma-next/migration-tools

npm i https://pkg.pr.new/@prisma-next/migration-tools@894

prisma-next

npm i https://pkg.pr.new/prisma-next@894

@prisma-next/vite-plugin-contract-emit

npm i https://pkg.pr.new/@prisma-next/vite-plugin-contract-emit@894

@prisma-next/mongo-codec

npm i https://pkg.pr.new/@prisma-next/mongo-codec@894

@prisma-next/mongo-contract

npm i https://pkg.pr.new/@prisma-next/mongo-contract@894

@prisma-next/mongo-value

npm i https://pkg.pr.new/@prisma-next/mongo-value@894

@prisma-next/mongo-contract-psl

npm i https://pkg.pr.new/@prisma-next/mongo-contract-psl@894

@prisma-next/mongo-contract-ts

npm i https://pkg.pr.new/@prisma-next/mongo-contract-ts@894

@prisma-next/mongo-emitter

npm i https://pkg.pr.new/@prisma-next/mongo-emitter@894

@prisma-next/mongo-schema-ir

npm i https://pkg.pr.new/@prisma-next/mongo-schema-ir@894

@prisma-next/mongo-query-ast

npm i https://pkg.pr.new/@prisma-next/mongo-query-ast@894

@prisma-next/mongo-orm

npm i https://pkg.pr.new/@prisma-next/mongo-orm@894

@prisma-next/mongo-query-builder

npm i https://pkg.pr.new/@prisma-next/mongo-query-builder@894

@prisma-next/mongo-lowering

npm i https://pkg.pr.new/@prisma-next/mongo-lowering@894

@prisma-next/mongo-wire

npm i https://pkg.pr.new/@prisma-next/mongo-wire@894

@prisma-next/sql-contract

npm i https://pkg.pr.new/@prisma-next/sql-contract@894

@prisma-next/sql-errors

npm i https://pkg.pr.new/@prisma-next/sql-errors@894

@prisma-next/sql-operations

npm i https://pkg.pr.new/@prisma-next/sql-operations@894

@prisma-next/sql-schema-ir

npm i https://pkg.pr.new/@prisma-next/sql-schema-ir@894

@prisma-next/sql-contract-psl

npm i https://pkg.pr.new/@prisma-next/sql-contract-psl@894

@prisma-next/sql-contract-ts

npm i https://pkg.pr.new/@prisma-next/sql-contract-ts@894

@prisma-next/sql-contract-emitter

npm i https://pkg.pr.new/@prisma-next/sql-contract-emitter@894

@prisma-next/sql-lane-query-builder

npm i https://pkg.pr.new/@prisma-next/sql-lane-query-builder@894

@prisma-next/sql-relational-core

npm i https://pkg.pr.new/@prisma-next/sql-relational-core@894

@prisma-next/sql-builder

npm i https://pkg.pr.new/@prisma-next/sql-builder@894

@prisma-next/target-postgres

npm i https://pkg.pr.new/@prisma-next/target-postgres@894

@prisma-next/target-sqlite

npm i https://pkg.pr.new/@prisma-next/target-sqlite@894

@prisma-next/adapter-postgres

npm i https://pkg.pr.new/@prisma-next/adapter-postgres@894

@prisma-next/adapter-sqlite

npm i https://pkg.pr.new/@prisma-next/adapter-sqlite@894

@prisma-next/driver-postgres

npm i https://pkg.pr.new/@prisma-next/driver-postgres@894

@prisma-next/driver-sqlite

npm i https://pkg.pr.new/@prisma-next/driver-sqlite@894

commit: 9d56e8e

[github-actions]

size-limit report 📦

Path	Size
postgres / no-emit	148.92 KB (-7.36% 🔽)
postgres / emit	126.45 KB (-14.49% 🔽)
mongo / no-emit	98.2 KB (0%)
mongo / emit	89.39 KB (0%)
cf-worker / no-emit	175.47 KB (-7.1% 🔽)
cf-worker / emit	150.97 KB (-13.33% 🔽)

[coderabbitai]

Actionable comments posted: 9

🧹 Nitpick comments (4)

packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts (1)

237-240: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Prefer blindCast over a bare as for this structural read.

As per coding guidelines: "No bare as in production code. Use blindCast<T, \"Reason\"> or castAs<T>".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts` around
lines 237 - 240, The structural read in verifier.ts uses a bare `as` cast, which
violates the casting guideline. Update the schema narrowing in the verifier
logic to use `blindCast<T, "Reason">` or `castAs<T>` instead of the direct
assertion, keeping the existing `schemaIntrospection` handling and the `schema`
variable in the same flow.

Source: Coding guidelines

packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts (1)

68-72: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Prefer blindCast over a bare as for this structural read.

The repo convention (and the sibling namespaceSchemaNodes helper this tree feeds) uses blindCast<T, "reason"> for exactly this kind of duck-typed structural read rather than a bare as.
As per coding guidelines: "No bare as in production code. Use blindCast<T, \"Reason\"> or castAs<T>".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts`
around lines 68 - 72, Replace the bare structural cast in the schema reader with
the repo-standard blindCast pattern. In project-schema-to-space’s schema
normalization logic, update the schemaObj assignment to use blindCast with an
explicit reason instead of a plain as cast, matching the convention used by
namespaceSchemaNodes and other duck-typed reads. Keep the inferred shape the
same while making the cast intent explicit and consistent with the coding
guidelines.

Source: Coding guidelines

packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts (1)

597-602: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

getPostgresVersion runs once per namespace though it's cluster-scoped.

introspectSchema calls getPostgresVersion at Line 1202, so a multi-namespace walk issues a SELECT version() per schema and the loop just overwrites pgVersion keeping only the last (Line 601). Consider hoisting the version query out of the per-namespace loop in introspect and dropping it from introspectSchema.

Also applies to: 1202-1202

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts` around
lines 597 - 602, `introspect` is doing a cluster-scoped PostgreSQL version
lookup once per schema and then overwriting the result in the `pgVersion`
accumulator. Hoist the `getPostgresVersion` call out of `introspectSchema` into
`introspect` so it runs once before the `resolvedSchemas` loop, pass the version
through as needed, and remove the version query from `introspectSchema` so it
only handles per-namespace introspection. Ensure the `introspect` and
`introspectSchema` flow still returns the same `pgVersion` value for all
namespaces.

packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts (1)

54-62: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Minor: annotations.pg.nativeEnumTypeNames reuses the raw input array, not the frozen copy.

Line 54 stores a defensively-copied, frozen nativeEnumTypeNames on the instance, but Lines 58-59 embed the original input.nativeEnumTypeNames reference inside annotations.pg. Depending on freezeNode's depth, this either leaves the annotation array externally mutable (shallow freeze) or mutates the caller's array to frozen as a side effect (deep freeze). Consider reusing this.nativeEnumTypeNames for the annotation to keep both consistent.

Proposed tweak

     this.nativeEnumTypeNames = Object.freeze([...input.nativeEnumTypeNames]);
     this.annotations = {
       pg: {
         schema: input.schemaName,
-        ...(input.nativeEnumTypeNames.length > 0 && {
-          nativeEnumTypeNames: input.nativeEnumTypeNames,
+        ...(this.nativeEnumTypeNames.length > 0 && {
+          nativeEnumTypeNames: this.nativeEnumTypeNames,
         }),
       },
     };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts`
around lines 54 - 62, `PostgresNamespaceSchemaNode` is putting the raw
`input.nativeEnumTypeNames` array into `annotations.pg` instead of the class’s
frozen copy. Update the constructor logic to reuse `this.nativeEnumTypeNames`
when building `annotations`, so `nativeEnumTypeNames` stays consistent with the
defensively copied instance state and avoids leaking the caller’s array
reference.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts`:
- Around line 241-254: The table-name collection in the schema helper is
returning duplicates when the same table exists under multiple namespaces, which
later causes duplicate orphan entries. Update the logic in the schema table-name
gathering path used by detectOrphanElements to dedupe names as they are
collected, ideally by switching the local accumulator from an array to a Set and
returning unique table names while preserving the existing
namespaces/schema.tables fallback behavior.

In `@packages/2-sql/9-family/src/core/control-adapter.ts`:
- Around line 212-218: The diffDatabaseSchema input currently omits
normalizeDefault and normalizeNativeType, so the shared diff path compares raw
defaults and types and can produce false drift. Update the diffDatabaseSchema
signature in control-adapter and any implementations/callers to accept these two
normalizer fields, then thread them through to the shared diff logic used by
diffDatabaseSchema so the target diff applies the normalizations consistently.

In `@packages/2-sql/9-family/src/core/control-instance.ts`:
- Around line 730-737: After `filterSchemaDiffIssues` removes structural issues
in `control-instance.ts`, recompute the `ok` state for the returned `sqlResult`
instead of returning it unchanged. Update the
`schemaDiffIssues`/`schema.counts.fail` branch so that `ok` reflects the
filtered schema issues, especially when the original failure was caused only by
suppressed structural diffs, and keep the logic localized around the
`schemaDiffIssues` and `relationalFails` handling.
- Around line 947-955: The table flattening in toSchemaView is dropping the
namespace identity, which causes duplicate SchemaTreeNode IDs for tables with
the same name in different schemas. Update the tableEntries construction in
control-instance.ts so each entry carries the namespace/schema name from
namespaceSchemaNodes, then use that namespace when building the table-level
nodes and IDs in the subsequent tableNodes mapping. Ensure the resulting
SchemaTreeNode labels and IDs stay unique for cases like public.users and
auth.users.

In `@packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts`:
- Around line 340-343: The strict extra-table claim check in verify-sql-schema
should be limited to the paired namespace set, not all contract namespaces.
Update the claimed-table scan in verifySqlSchema (including the same logic used
around the missing-table handling and the matching block at the later location)
so it skips namespaces not present in restrictToNamespaceIds when that set is
provided. This will keep tree verification from letting a table claimed in auth
mask an unexpected same-named table in the public actual node.
- Around line 1407-1426: `mergeVerifyResults` is merging `schema.counts`
correctly but leaving `summary` from the first result, which can make
multi-namespace failures report stale counts. Update `mergeVerifyResults` in
`verify-sql-schema.ts` so the merged result recomputes `summary` from the
combined `a.schema` and `b.schema` data after summing counts, rather than
reusing `a.summary`; use the existing `mergeVerifyResults` flow and the
`schema`/`counts` fields to keep the summary consistent with the merged totals.

In `@packages/3-targets/3-targets/postgres/package.json`:
- Line 38: The dependency entry for `@prisma-next/psl-printer` in the postgres
package.json uses workspace:* instead of the repo’s pinned internal version
convention. Update this package’s internal `@prisma-next/`* dependency to use the
same literal workspace version string as the other internal deps in this
manifest, keeping the existing dependency naming intact.

In `@packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts`:
- Around line 393-400: The namespace selection logic in namespaceSchemaNode is
too permissive because it falls back to namespaceNodes[0] even when multiple
namespaces exist and none match schemaName. Update the helper so it only returns
the first namespace for the single-namespace case, and otherwise returns no
match or raises the appropriate ambiguity handling for relational planning. Keep
the lookup tied to namespaceSchemaNodes and the byName selection so ambiguous
schema matches do not silently probe the wrong namespace.

In `@packages/3-targets/3-targets/postgres/test/rls-diffable-nodes.test.ts`:
- Around line 60-77: The role fixture in the Postgres diffable nodes tests is
using the wrong namespace coordinate for PostgresRole. Update the relevant role
assertions and any similar fixtures to use the cluster-scoped namespace sentinel
UNBOUND_NAMESPACE_ID instead of public, so the tests match the PostgresRole
contract while still verifying kind and name through the PostgresRole
constructor-based fixtures.

---

Nitpick comments:
In
`@packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts`:
- Around line 68-72: Replace the bare structural cast in the schema reader with
the repo-standard blindCast pattern. In project-schema-to-space’s schema
normalization logic, update the schemaObj assignment to use blindCast with an
explicit reason instead of a plain as cast, matching the convention used by
namespaceSchemaNodes and other duck-typed reads. Keep the inferred shape the
same while making the cast intent explicit and consistent with the coding
guidelines.

In `@packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts`:
- Around line 237-240: The structural read in verifier.ts uses a bare `as` cast,
which violates the casting guideline. Update the schema narrowing in the
verifier logic to use `blindCast<T, "Reason">` or `castAs<T>` instead of the
direct assertion, keeping the existing `schemaIntrospection` handling and the
`schema` variable in the same flow.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts`:
- Around line 54-62: `PostgresNamespaceSchemaNode` is putting the raw
`input.nativeEnumTypeNames` array into `annotations.pg` instead of the class’s
frozen copy. Update the constructor logic to reuse `this.nativeEnumTypeNames`
when building `annotations`, so `nativeEnumTypeNames` stays consistent with the
defensively copied instance state and avoids leaking the caller’s array
reference.

In `@packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts`:
- Around line 597-602: `introspect` is doing a cluster-scoped PostgreSQL version
lookup once per schema and then overwriting the result in the `pgVersion`
accumulator. Hoist the `getPostgresVersion` call out of `introspectSchema` into
`introspect` so it runs once before the `resolvedSchemas` loop, pass the version
through as needed, and remove the version query from `introspectSchema` so it
only handles per-namespace introspection. Ensure the `introspect` and
`introspectSchema` flow still returns the same `pgVersion` value for all
namespaces.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 28eb30df-16d3-4255-8569-8ba7e658c740

📥 Commits

Reviewing files that changed from the base of the PR and between d987376 and 91248f6.

⛔ Files ignored due to path filters (4)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
• projects/postgres-rls/plan.md is excluded by !projects/**
• projects/postgres-rls/slices/schema-node-tree-restructure/design.md is excluded by !projects/**
• projects/postgres-rls/slices/schema-node-tree-restructure/spec.md is excluded by !projects/**

📒 Files selected for processing (97)

• packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts
• packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts
• packages/1-framework/3-tooling/migration/test/aggregate/project-schema-to-space.test.ts
• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir.ts
• packages/2-sql/9-family/package.json
• packages/2-sql/9-family/src/core/control-adapter.ts
• packages/2-sql/9-family/src/core/control-instance.ts
• packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts
• packages/2-sql/9-family/src/core/migrations/types.ts
• packages/2-sql/9-family/src/core/psl-contract-infer/printer-config.ts
• packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts
• packages/2-sql/9-family/src/exports/control.ts
• packages/2-sql/9-family/src/exports/psl-infer.ts
• packages/2-sql/9-family/src/exports/schema-verify.ts
• packages/2-sql/9-family/test/psl-contract-infer/default-mapping.test.ts
• packages/2-sql/9-family/tsdown.config.ts
• packages/3-extensions/pgvector/test/migrations/planner.behavior.test.ts
• packages/3-extensions/pgvector/test/migrations/planner.contract-to-schema-ir.test.ts
• packages/3-extensions/pgvector/test/migrations/planner.storage-types.test.ts
• packages/3-targets/3-targets/postgres/package.json
• packages/3-targets/3-targets/postgres/src/core/authoring.ts
• packages/3-targets/3-targets/postgres/src/core/entity-kinds.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-schema-ir.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-postgres-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/op-factory-call.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/operations/rls.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/runner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/verify-postgres-namespaces.ts
• packages/3-targets/3-targets/postgres/src/core/postgres-rls-policy.ts
• packages/3-targets/3-targets/postgres/src/core/postgres-role.ts
• packages/3-targets/3-targets/postgres/src/core/postgres-schema.ts
• packages/3-targets/3-targets/postgres/src/core/psl-infer/infer-psl-contract.ts
• packages/3-targets/3-targets/postgres/src/core/psl-infer/postgres-default-mapping.ts
• packages/3-targets/3-targets/postgres/src/core/psl-infer/postgres-type-map.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-role-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-schema-ir-annotations.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-schema-ir.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts
• packages/3-targets/3-targets/postgres/src/exports/control.ts
• packages/3-targets/3-targets/postgres/src/exports/planner.ts
• packages/3-targets/3-targets/postgres/src/exports/types.ts
• packages/3-targets/3-targets/postgres/test/migrations/contract-to-postgres-database-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/contract-to-postgres-schema-ir.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/diff-postgres-schema.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/rls-ops.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/rls-planner.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/verify-postgres-namespaces.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-contract-serializer.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-database-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-namespace-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-table-ir.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-table-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/fixtures.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/infer-psl-contract.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/postgres-type-map.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/print-psl/print-psl.core.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/print-psl/print-psl.defaults-and-types.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/print-psl/print-psl.enums.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/print-psl/print-psl.naming-and-constraints.test.ts
• packages/3-targets/3-targets/postgres/test/psl-infer/print-psl/print-psl.relations.test.ts
• packages/3-targets/3-targets/postgres/test/psl-policy-authoring.test.ts
• packages/3-targets/3-targets/postgres/test/rls-diffable-nodes.test.ts
• packages/3-targets/3-targets/postgres/test/rls-ir-kinds.test.ts
• packages/3-targets/3-targets/postgres/test/schema-ir-leaf-nodes.test.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/planner.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/runner.ts
• packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts
• packages/3-targets/6-adapters/postgres/test/control-adapter.check-constraints.test.ts
• packages/3-targets/6-adapters/postgres/test/control-adapter.defaults.test.ts
• packages/3-targets/6-adapters/postgres/test/control-adapter.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/array-column-introspection.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/fixtures/runner-fixtures.ts
• packages/3-targets/6-adapters/postgres/test/migrations/index-introspection.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.authoring-surface.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.codec-field-event.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.cross-space-fk-ddl.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.fk-config.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.reconciliation.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.reconciliation.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.referential-actions.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/planner.semantic-satisfaction.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-collect-extension-issues.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-introspection.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-lifecycle-e2e.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-migration-plan.integration.test.ts
• test/integration/test/control-api.test.ts
• test/integration/test/cross-package/postgres-control-policy-planner.test.ts
• test/integration/test/family.introspect.integration.test.ts
• test/integration/test/family.introspect.test.ts
• test/integration/test/referential-actions.integration.test.ts

💤 Files with no reviewable changes (4)

• packages/3-targets/3-targets/postgres/test/migrations/contract-to-postgres-schema-ir.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-table-ir.test.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-schema-ir.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-schema-ir.ts

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check combined diff implementations and whether they pass default/native-type normalizers.
rg -n -C4 '\bdiffDatabaseSchema\b|normalizeDefault|normalizeNativeType|verifySqlSchema(Tree)?\b' packages/2-sql/9-family packages/3-targets

Repository: prisma/prisma-next

Length of output: 50375

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Map the relevant files and inspect the exact diff/normalizer flow.
files=(
  packages/2-sql/9-family/src/core/control-adapter.ts
  packages/2-sql/9-family/src/core/control-instance.ts
  packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts
)

for f in "${files[@]}"; do
  echo "### $f"
  wc -l "$f"
  ast-grep outline "$f" --view expanded || true
  echo
done

Repository: prisma/prisma-next

Length of output: 5753

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Read the core flow around the new hook and the old fallback path.
sed -n '1,260p' packages/2-sql/9-family/src/core/control-instance.ts
echo '---'
sed -n '1,280p' packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts
echo '---'
sed -n '1,280p' packages/2-sql/9-family/src/core/control-adapter.ts

Repository: prisma/prisma-next

Length of output: 28510

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find every diffDatabaseSchema implementation and its local helpers.
rg -n -C6 '\bdiffDatabaseSchema\b|normalizeDefault|normalizeNativeType|verifySqlSchema(Tree)?\b' \
  packages/2-sql/9-family/src \
  packages/3-targets

Repository: prisma/prisma-next

Length of output: 50374

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Narrow reads around the changed control flow.
for f in \
  packages/2-sql/9-family/src/core/control-instance.ts \
  packages/2-sql/9-family/src/core/control-adapter.ts \
  packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts
do
  echo "### $f"
  nl -ba "$f" | sed -n '1,260p' | sed -n '1,240p'
  echo
done

Repository: prisma/prisma-next

Length of output: 254

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate source implementations only.
rg -n -C5 '\bdiffDatabaseSchema\b' \
  packages/2-sql/9-family/src \
  packages/3-targets \
  --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 7259

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find the concrete hook implementation(s) and the call site.
rg -n -C3 '\bdiffDatabaseSchema\b' packages --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 4807

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Search source for the normalizer hooks and the new diff hook.
rg -n -C4 '\bnormalizeDefault\b|\bnormalizeNativeType\b|\bdiffDatabaseSchema\b' \
  packages/2-sql/9-family/src \
  --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 25925

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the mock target component shape used by schema verification tests.
rg -n -C8 'createMockPostgresComponent|normalizeDefault|normalizeNativeType|frameworkComponents' \
  packages/2-sql/9-family/test packages/2-sql/9-family/src \
  --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 50374

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find helper files that define the test components and normalizers.
fd -a 'schema-verify.helpers.ts|control-policy' packages/2-sql/9-family/test packages/2-sql/9-family/src

Repository: prisma/prisma-next

Length of output: 466

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the concrete diffDatabaseSchema implementation bodies.
sed -n '130,240p' packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts
echo '---'
sed -n '120,220p' packages/3-targets/6-adapters/sqlite/src/core/control-adapter.ts

Repository: prisma/prisma-next

Length of output: 8609

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the shared Postgres diff implementation for normalizer handling.
rg -n -C6 'function diffPostgresDatabaseSchema|const diffPostgresDatabaseSchema|diffPostgresDatabaseSchema\(' \
  packages/3-targets/6-adapters/postgres/src \
  --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 1665

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate the function definition and inspect its parameter list / body.
rg -n -C8 '^function diffPostgresDatabaseSchema|^const diffPostgresDatabaseSchema|^export function diffPostgresDatabaseSchema|diffPostgresDatabaseSchema\s*=\s*\(' \
  packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts

Repository: prisma/prisma-next

Length of output: 156

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find where diffPostgresDatabaseSchema is defined and what it closes over.
rg -n -C6 '\bdiffPostgresDatabaseSchema\b' packages --glob '!**/*.test.*'

Repository: prisma/prisma-next

Length of output: 13209

---

Thread normalizers through diffDatabaseSchema The combined diff path currently has no way to receive normalizeDefault / normalizeNativeType, so the target diff compares raw defaults and types and can report false drift. Add these fields to the input and pass them into the shared diff.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-adapter.ts` around lines 212 - 218,
The diffDatabaseSchema input currently omits normalizeDefault and
normalizeNativeType, so the shared diff path compares raw defaults and types and
can produce false drift. Update the diffDatabaseSchema signature in
control-adapter and any implementations/callers to accept these two normalizer
fields, then thread them through to the shared diff logic used by
diffDatabaseSchema so the target diff applies the normalizations consistently.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Recompute ok after structural diff suppression.

If filterSchemaDiffIssues suppresses all structural issues, this branch returns the original sqlResult; when that result was failed only because of those structural issues, verify still fails incorrectly.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-instance.ts` around lines 730 - 737,
After `filterSchemaDiffIssues` removes structural issues in
`control-instance.ts`, recompute the `ok` state for the returned `sqlResult`
instead of returning it unchanged. Update the
`schemaDiffIssues`/`schema.counts.fail` branch so that `ok` reflects the
filtered schema issues, especially when the original failure was caused only by
suppressed structural diffs, and keep the logic localized around the
`schemaDiffIssues` and `relationalFails` handling.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Scope strict extra-table claims to the paired namespace set.

Line 343 restricts missing-table checks, but the strict claimed check still scans every contract namespace. In tree verification, a contract table in auth can hide an unexpected same-named table in the public actual node.

Proposed fix

   const namespaceIds = Object.keys(contract.storage.namespaces).sort((a, b) =>
     a < b ? -1 : a > b ? 1 : 0,
   );
+  const claimNamespaceIds = restrictToNamespaceIds ?? new Set(namespaceIds);
@@
   if (strict) {
     for (const tableName of Object.keys(schemaTables)) {
-      const claimed = namespaceIds.some(
-        (namespaceId) =>
-          contract.storage.namespaces[namespaceId]?.entries.table?.[tableName] !== undefined,
-      );
+      let claimed = false;
+      for (const namespaceId of claimNamespaceIds) {
+        if (contract.storage.namespaces[namespaceId]?.entries.table?.[tableName] !== undefined) {
+          claimed = true;
+          break;
+        }
+      }
       if (!claimed) {

Also applies to: 407-412

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts` around
lines 340 - 343, The strict extra-table claim check in verify-sql-schema should
be limited to the paired namespace set, not all contract namespaces. Update the
claimed-table scan in verifySqlSchema (including the same logic used around the
missing-table handling and the matching block at the later location) so it skips
namespaces not present in restrictToNamespaceIds when that set is provided. This
will keep tree verification from letting a table claimed in auth mask an
unexpected same-named table in the public actual node.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Recompute the merged summary after summing counts.

mergeVerifyResults sums counts.fail but keeps a.summary, so multi-namespace failures can report the first namespace’s failure count while returning larger merged counts.

Proposed fix

 function mergeVerifyResults(
   a: VerifyDatabaseSchemaResult,
   b: VerifyDatabaseSchemaResult,
 ): VerifyDatabaseSchemaResult {
+  const counts = {
+    pass: a.schema.counts.pass + b.schema.counts.pass,
+    warn: a.schema.counts.warn + b.schema.counts.warn,
+    fail: a.schema.counts.fail + b.schema.counts.fail,
+    totalNodes: a.schema.counts.totalNodes + b.schema.counts.totalNodes,
+  };
+  const ok = a.ok && b.ok;
   return {
     ...a,
-    ok: a.ok && b.ok,
-    ...ifDefined('code', a.code ?? b.code),
+    ok,
+    ...ifDefined('code', ok ? undefined : (a.code ?? b.code)),
+    summary: ok
+      ? 'Database schema satisfies contract'
+      : `Database schema does not satisfy contract (${counts.fail} failure${counts.fail === 1 ? '' : 's'})`,
     schema: {
       ...a.schema,
       issues: [...a.schema.issues, ...b.schema.issues],
       schemaDiffIssues: [...a.schema.schemaDiffIssues, ...b.schema.schemaDiffIssues],
-      counts: {
-        pass: a.schema.counts.pass + b.schema.counts.pass,
-        warn: a.schema.counts.warn + b.schema.counts.warn,
-        fail: a.schema.counts.fail + b.schema.counts.fail,
-        totalNodes: a.schema.counts.totalNodes + b.schema.counts.totalNodes,
-      },
+      counts,
     },
   };
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	function mergeVerifyResults(
	a: VerifyDatabaseSchemaResult,
	b: VerifyDatabaseSchemaResult,
	): VerifyDatabaseSchemaResult {
	return {
	...a,
	ok: a.ok && b.ok,
	...ifDefined('code', a.code ?? b.code),
	schema: {
	...a.schema,
	issues: [...a.schema.issues, ...b.schema.issues],
	schemaDiffIssues: [...a.schema.schemaDiffIssues, ...b.schema.schemaDiffIssues],
	counts: {
	pass: a.schema.counts.pass + b.schema.counts.pass,
	warn: a.schema.counts.warn + b.schema.counts.warn,
	fail: a.schema.counts.fail + b.schema.counts.fail,
	totalNodes: a.schema.counts.totalNodes + b.schema.counts.totalNodes,
	},
	},
	};
	function mergeVerifyResults(
	a: VerifyDatabaseSchemaResult,
	b: VerifyDatabaseSchemaResult,
	): VerifyDatabaseSchemaResult {
	const counts = {
	pass: a.schema.counts.pass + b.schema.counts.pass,
	warn: a.schema.counts.warn + b.schema.counts.warn,
	fail: a.schema.counts.fail + b.schema.counts.fail,
	totalNodes: a.schema.counts.totalNodes + b.schema.counts.totalNodes,
	};
	const ok = a.ok && b.ok;
	return {
	...a,
	ok,
	...ifDefined('code', ok ? undefined : (a.code ?? b.code)),
	summary: ok
	? 'Database schema satisfies contract'
	: `Database schema does not satisfy contract (${counts.fail} failure${counts.fail === 1 ? '' : 's'})`,
	schema: {
	...a.schema,
	issues: [...a.schema.issues, ...b.schema.issues],
	schemaDiffIssues: [...a.schema.schemaDiffIssues, ...b.schema.schemaDiffIssues],
	counts,
	},
	};
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/schema-verify/verify-sql-schema.ts` around
lines 1407 - 1426, `mergeVerifyResults` is merging `schema.counts` correctly but
leaving `summary` from the first result, which can make multi-namespace failures
report stale counts. Update `mergeVerifyResults` in `verify-sql-schema.ts` so
the merged result recomputes `summary` from the combined `a.schema` and
`b.schema` data after summing counts, rather than reusing `a.summary`; use the
existing `mergeVerifyResults` flow and the `schema`/`counts` fields to keep the
summary consistent with the merged totals.

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the repo’s literal workspace version for internal deps.

workspace:* bypasses the repo’s pinned internal dependency convention; match the package version used by the other @prisma-next/* entries.

Based on learnings, workspace package.json dependencies/devDependencies for internal Prisma Next packages should use workspace:<literal-version> rather than workspace:*.

Proposed fix

-    "`@prisma-next/psl-printer`": "workspace:*",
+    "`@prisma-next/psl-printer`": "workspace:0.14.0",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"@prisma-next/psl-printer": "workspace:*",
	"`@prisma-next/psl-printer`": "workspace:0.14.0",

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-targets/3-targets/postgres/package.json` at line 38, The
dependency entry for `@prisma-next/psl-printer` in the postgres package.json uses
workspace:* instead of the repo’s pinned internal version convention. Update
this package’s internal `@prisma-next/`* dependency to use the same literal
workspace version string as the other internal deps in this manifest, keeping
the existing dependency naming intact.

Source: Learnings

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Avoid silently probing the first namespace on ambiguous matches.

The helper documents falling back only for the single-schema case, but Line 399 returns the first namespace even when multiple namespaces exist and none match schemaName. That can make relational strategies probe the wrong schema and reintroduce cross-schema table-name collisions.

Proposed fix

   const byName = namespaceNodes.find(
     (node) =>
       blindCast<{ readonly schemaName?: string }, 'reading the namespace node schema name'>(node)
         .schemaName === schemaName,
   );
-  return byName ?? namespaceNodes[0];
+  if (byName !== undefined) {
+    return byName;
+  }
+  return namespaceNodes.length === 1 ? namespaceNodes[0] : undefined;
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const namespaceNodes = namespaceSchemaNodes(schema);
	const byName = namespaceNodes.find(
	(node) =>
	blindCast<{ readonly schemaName?: string }, 'reading the namespace node schema name'>(node)
	.schemaName === schemaName,
	);
	return byName ?? namespaceNodes[0];
	}
	const namespaceNodes = namespaceSchemaNodes(schema);
	const byName = namespaceNodes.find(
	(node) =>
	blindCast<{ readonly schemaName?: string }, 'reading the namespace node schema name'>(node)
	.schemaName === schemaName,
	);
	if (byName !== undefined) {
	return byName;
	}
	return namespaceNodes.length === 1 ? namespaceNodes[0] : undefined;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts` around
lines 393 - 400, The namespace selection logic in namespaceSchemaNode is too
permissive because it falls back to namespaceNodes[0] even when multiple
namespaces exist and none match schemaName. Update the helper so it only returns
the first namespace for the single-namespace case, and otherwise returns no
match or raises the appropriate ambiguity handling for relational planning. Keep
the lookup tied to namespaceSchemaNodes and the byName selection so ambiguous
schema matches do not silently probe the wrong namespace.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use the cluster-scoped namespace sentinel in role fixtures.

PostgresRole is documented as always using UNBOUND_NAMESPACE_ID; these tests currently assert public, which codifies an invalid role coordinate.

Proposed test fix

+import { UNBOUND_NAMESPACE_ID } from '`@prisma-next/framework-components/ir`';
 import { describe, expect, it } from 'vitest';
@@
-  const role = new PostgresRole({ name: 'app_user', namespaceId: 'public' });
+  const role = new PostgresRole({ name: 'app_user', namespaceId: UNBOUND_NAMESPACE_ID });
@@
-    expect(role.namespaceId).toBe('public');
+    expect(role.namespaceId).toBe(UNBOUND_NAMESPACE_ID);
@@
-    const role = new PostgresRole({ name: 'anon', namespaceId: 'public' });
+    const role = new PostgresRole({ name: 'anon', namespaceId: UNBOUND_NAMESPACE_ID });
@@
-    const role = new PostgresRole({ name: 'anon', namespaceId: 'public' });
+    const role = new PostgresRole({ name: 'anon', namespaceId: UNBOUND_NAMESPACE_ID });

Also applies to: 104-106, 128-130

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-targets/3-targets/postgres/test/rls-diffable-nodes.test.ts` around
lines 60 - 77, The role fixture in the Postgres diffable nodes tests is using
the wrong namespace coordinate for PostgresRole. Update the relevant role
assertions and any similar fixtures to use the cluster-scoped namespace sentinel
UNBOUND_NAMESPACE_ID instead of public, so the tests match the PostgresRole
contract while still verifying kind and name through the PostgresRole
constructor-based fixtures.

[wmadden]

Completely unacceptable

[coderabbitai]

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (4)

packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts (1)

229-253: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Dedupe live entity names before building orphan list.

listEntityNames has no uniqueness contract (readonly string[]). If any family's implementation returns the same entity name twice (e.g., unclaimed same-named table in two Postgres namespaces), orphans will contain duplicate entries — the same class of bug flagged in a prior review on the old collectLiveTableNames path, now reachable again via the delegated callback.

🐛 Proposed fix

 function detectOrphanElements(
   schemaIntrospection: unknown,
   members: ReadonlyArray<ContractSpaceMember>,
   listEntityNames: ListSchemaEntityNames,
 ): readonly OrphanElement[] {
-  const liveTableNames = listEntityNames(schemaIntrospection);
-  if (liveTableNames.length === 0) return [];
+  const liveTableNames = new Set(listEntityNames(schemaIntrospection));
+  if (liveTableNames.size === 0) return [];

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts` around
lines 229 - 253, The orphan detection in detectOrphanElements can emit duplicate
table entries because listEntityNames() returns a plain string array with no
uniqueness guarantee. Deduplicate the live table names before iterating them to
build orphans, then keep the existing claimedTables membership check and final
sort so detectOrphanElements only returns one orphan per entity name.

packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts (1)

556-586: 🚀 Performance & Scalability | 🟡 Minor | ⚡ Quick win

Redundant per-namespace getPostgresVersion round trip.

introspectSchema calls this.getPostgresVersion(driver) (line 1176) on every iteration of the introspect() loop (lines 572-576), even though the Postgres version is database-wide, not namespace-scoped. For N namespaces this issues N-1 unnecessary round trips fetching the same value repeatedly.

♻️ Hoist the version lookup out of the per-namespace loop

     const namespaces: Record<string, PostgresNamespaceSchemaNode> = {};
-    let pgVersion = 'unknown';
+    const pgVersion = await this.getPostgresVersion(driver);
     for (const resolved of resolvedSchemas) {
-      const { namespace, pgVersion: version } = await this.introspectSchema(driver, resolved);
+      const { namespace } = await this.introspectSchema(driver, resolved);
       namespaces[resolved] = namespace;
-      pgVersion = version;
     }

And drop pgVersion from introspectSchema's return value/query accordingly.

Also applies to: 660-663, 1176-1176

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts` around
lines 556 - 586, The introspection flow is doing a redundant database-wide
Postgres version lookup inside each namespace pass. Hoist the version fetch out
of `introspect()` and `introspectSchema()` so `getPostgresVersion(driver)` runs
once per `introspect` call, then pass the single version through to
`PostgresDatabaseSchemaNode`; update `introspectSchema` to stop returning
`pgVersion` and remove any per-namespace version query usage.

packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts (2)

378-404: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Unused annotationNamespace validation in contractNamespaceToSchemaIR.

The empty-string check on options.annotationNamespace (line 383) guards a value that this function never actually uses — no annotations are derived or returned here, unlike contractToSchemaIR. This looks like leftover copy-paste from the sibling function.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts` around
lines 378 - 404, Remove the unnecessary annotationNamespace empty-string
validation from contractNamespaceToSchemaIR, since this function does not use
annotationNamespace at all. Keep the rest of the namespace-to-schema conversion
logic intact in contractNamespaceToSchemaIR, and leave annotationNamespace
validation only in the path where it is actually consumed, such as
contractToSchemaIR.

---

378-451: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicated table-conversion loop between contractNamespaceToSchemaIR and contractToSchemaIR.

Both functions independently build storageTypes from storage.types and iterate entries.table to call convertTable/assertStorageTable. Consider having contractToSchemaIR delegate per-namespace conversion to contractNamespaceToSchemaIR (layering the cross-namespace duplicate-table check and deriveAnnotations on top) to avoid drift between the two implementations.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts` around
lines 378 - 451, Both `contractNamespaceToSchemaIR` and `contractToSchemaIR`
duplicate the same storage-type setup and table conversion logic, so refactor to
reuse the namespace-level conversion path instead of maintaining two loops. Make
`contractToSchemaIR` delegate per namespace to `contractNamespaceToSchemaIR` or
extract the shared `assertStorageTable`/`convertTable` iteration into a helper,
while keeping the cross-namespace duplicate-table guard and `deriveAnnotations`
only in `contractToSchemaIR`. This keeps the behavior in sync and avoids drift
between `contractNamespaceToSchemaIR`, `contractToSchemaIR`, and `convertTable`.

♻️ Duplicate comments (4)

packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts (1)

97-99: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

isEqualTo doesn't validate node kind (see policy node comment).

Consistent with the general design (identity-based equality), but unlike PostgresPolicySchemaNode.isEqualTo, this compares this.id === other.id without confirming other is actually a PostgresTableSchemaNode. Low practical risk since the differ pairs same-kind nodes structurally, but flagging alongside the corresponding comment in postgres-policy-schema-node.ts for consistency.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts`
around lines 97 - 99, Update PostgresTableSchemaNode.isEqualTo to mirror the
kind-checking pattern used in PostgresPolicySchemaNode.isEqualTo: verify the
other node is actually a PostgresTableSchemaNode before comparing ids, then keep
the identity-based id comparison only after that guard. This keeps equality
consistent with the schema node design and avoids treating different node kinds
as equal when ids collide.

packages/2-sql/9-family/src/core/migrations/types.ts (1)

509-515: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

DiffDatabaseSchemaInput still omits normalizer hooks.

DiffDatabaseSchemaInput carries contract, schema, strict, typeMetadataRegistry, frameworkComponents but no normalizeDefault / normalizeNativeType. Per the graph evidence, PostgresMigrationPlanner.planSql calls diffPostgresDatabaseSchema with exactly this input shape (no normalizers passed), so the combined database-schema diff compares raw introspected defaults/native types against contract-declared ones with no normalization — even though SqlControlAdapter.normalizeDefault/normalizeNativeType exist precisely for this purpose and are consumed elsewhere (verifySqlSchema/verifySqlSchemaTree). This can produce false-positive drift in both db verify and migration planning for targets whose adapter defines these normalizers.

This is the same concern raised in a previous review round on this PR, now relocated to this interface after diffDatabaseSchema moved from the adapter to the target descriptor.

♻️ Suggested fix

 export interface DiffDatabaseSchemaInput {
   readonly contract: Contract<SqlStorage>;
   readonly schema: SqlSchemaIRNode;
   readonly strict: boolean;
   readonly typeMetadataRegistry: ReadonlyMap<string, { readonly nativeType?: string }>;
   readonly frameworkComponents: ReadonlyArray<TargetBoundComponentDescriptor<'sql', string>>;
+  readonly normalizeDefault?: DefaultNormalizer;
+  readonly normalizeNativeType?: NativeTypeNormalizer;
 }

Thread these through to each diffDatabaseSchema implementation (Postgres, SQLite) and their call sites (planner, verify path) from the adapter's normalizeDefault/normalizeNativeType.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/migrations/types.ts` around lines 509 - 515,
`DiffDatabaseSchemaInput` is missing the adapter normalization hooks needed by
schema diffing. Add `normalizeDefault` and `normalizeNativeType` to
`DiffDatabaseSchemaInput`, then thread them from the relevant
`SqlControlAdapter` into `diffDatabaseSchema`/`diffPostgresDatabaseSchema` call
sites such as `PostgresMigrationPlanner.planSql` and the verify path. Update the
`diffDatabaseSchema` implementations for Postgres and SQLite to use these hooks
when comparing defaults/native types, matching the existing behavior in
`verifySqlSchema` and `verifySqlSchemaTree`.

packages/2-sql/9-family/src/core/control-instance.ts (2)

972-995: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Namespace identity is still lost when flattening tables for toSchemaView.

tableEntries flattens root.namespaces/root.tables and later builds IDs purely from tableName (e.g. table-${tableName}, column-${tableName}-${columnName}). Two tables with the same name in different namespaces (e.g. public.users and auth.users) still collide on identical SchemaTreeNode IDs and labels, exactly as previously flagged.

🐛 Proposed fix

-      const tableEntries: ReadonlyArray<[string, SqlTableIR]> = tableRecords.flatMap((tables) =>
-        Object.entries(tables),
-      );
+      const tableEntries: ReadonlyArray<[string, SqlTableIR]> =
+        root.namespaces !== undefined
+          ? Object.entries(root.namespaces).flatMap(([nsKey, namespace]) =>
+              Object.entries(namespace.tables).map(
+                ([tableName, table]) => [`${nsKey}.${tableName}`, table] as [string, SqlTableIR],
+              ),
+            )
+          : Object.entries(root.tables ?? {});

This still requires threading the qualified key through the column-, primary-key-, unique-, and index- ID templates below (they currently reuse the bare tableName too).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-instance.ts` around lines 972 - 995,
`toSchemaView` still drops namespace identity when flattening schema tables,
causing ID collisions for same-named tables across namespaces. Update the table
flattening in `toSchemaView` so each entry carries its namespace-qualified key
(or equivalent unique table identifier), then use that qualified value when
generating `SchemaTreeNode` IDs and labels in the table, column, primary-key,
unique, and index node creation paths. Keep the existing structure of
`tableRecords`/`tableEntries`, but thread the namespace-qualified identifier
through the later mappings instead of reusing bare `tableName`.

---

722-752: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

ok/code/summary are not recomputed when control-policy suppression empties schemaDiffIssues.

The else branch proves sqlResult.schema.counts.fail (aka relationalFails) excludes schemaDiffIssues — it explicitly adds schemaDiffIssues.length back in via totalFails = relationalFails + schemaDiffIssues.length. That means diffDatabaseSchema's own ok was computed from the unfiltered schemaDiffIssues (since it isn't passed the control policy). When filterSchemaDiffIssues suppresses every structural issue down to zero, the schemaDiffIssues.length === 0 branch returns sqlResult (or a shallow variant) with the stale ok/code/summary from before filtering — if the pre-filter failure was caused solely by the now-suppressed issues, verifySchema still reports failure.

🐛 Proposed fix

       const schemaDiffIssues = filterSchemaDiffIssues(
         sqlResult.schema.schemaDiffIssues,
         contract.defaultControlPolicy,
       );
       const relationalFails = sqlResult.schema.counts.fail;
-      if (schemaDiffIssues.length === 0) {
-        if (schemaDiffIssues === sqlResult.schema.schemaDiffIssues) return sqlResult;
-        return { ...sqlResult, schema: { ...sqlResult.schema, schemaDiffIssues } };
-      }
-      const totalFails = relationalFails + schemaDiffIssues.length;
+      if (
+        schemaDiffIssues === sqlResult.schema.schemaDiffIssues &&
+        schemaDiffIssues.length === sqlResult.schema.schemaDiffIssues.length
+      ) {
+        return sqlResult;
+      }
+      const totalFails = relationalFails + schemaDiffIssues.length;
+      const ok = totalFails === 0;
       return {
         ...sqlResult,
-        ok: false,
-        code: sqlResult.code ?? 'PN-RUN-3010',
-        summary: `Database schema does not satisfy contract (${totalFails} failure${totalFails === 1 ? '' : 's'})`,
+        ok,
+        ...(ok
+          ? {}
+          : {
+              code: sqlResult.code ?? 'PN-RUN-3010',
+              summary: `Database schema does not satisfy contract (${totalFails} failure${totalFails === 1 ? '' : 's'})`,
+            }),
         schema: {
           ...sqlResult.schema,
           schemaDiffIssues,
           counts: { ...sqlResult.schema.counts, fail: totalFails },
         },
       };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-instance.ts` around lines 722 - 752,
In verifySchema, the returned sqlResult can keep stale ok/code/summary values
after filterSchemaDiffIssues removes all structural issues, because
diffDatabaseSchema was computed before control-policy suppression. Update the
VerifySchema path to recompute the result status from the filtered
schemaDiffIssues and relationalFails whenever the filtered list differs from
sqlResult.schema.schemaDiffIssues, including the zero-issue case, so the
returned schema summary matches the post-filter counts.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/1-framework/3-tooling/cli/src/control-api/operations/db-run.ts`:
- Around line 188-195: The duplicated `projectSchemaToMember` delegation in
`db-run.ts` and `db-verify.ts` should be factored into a shared CLI helper
instead of repeating the same `blindCast` wrapper and comment. Extract a small
utility in a common control-api/CLI module that accepts the schema and
`ownedByOtherNames`, performs the `familyInstance.projectSchemaToMember` call,
and reuse it from both operations to keep the cast and opaque-schema
justification in one place.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-database-schema-node.ts`:
- Around line 68-70: Update PostgresDatabaseSchemaNode.isEqualTo to match the
stricter comparison behavior used by PostgresRoleSchemaNode: validate that the
other DiffableNode is the expected node kind before comparing ids, and throw or
otherwise fail on mismatched kinds instead of returning a false positive. Keep
the comparison logic within isEqualTo consistent with the nodeKind-based guard
already used elsewhere so future tree-shape changes do not hide cross-type
comparisons.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts`:
- Around line 54-56: The `isEqualTo` implementation on
`PostgresNamespaceSchemaNode` only compares `id` and does not verify that
`other` is the same node type. Update this method to first check that `other` is
a `PostgresNamespaceSchemaNode`, following the stricter pattern used by
`PostgresRoleSchemaNode.isEqualTo`, and only then compare identifiers.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts`:
- Around line 73-84: The PostgresPolicySchemaNode.isEqualTo implementation is
the only sibling that performs an explicit kind check before comparing ids,
making it inconsistent with the other schema nodes. Align it with the other
isEqualTo methods in the same diff by either removing the
PostgresPolicySchemaNode.is(node) guard and relying on the id comparison like
the table/namespace/database nodes, or applying the same kind validation pattern
consistently across all sibling nodes.

---

Outside diff comments:
In `@packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts`:
- Around line 229-253: The orphan detection in detectOrphanElements can emit
duplicate table entries because listEntityNames() returns a plain string array
with no uniqueness guarantee. Deduplicate the live table names before iterating
them to build orphans, then keep the existing claimedTables membership check and
final sort so detectOrphanElements only returns one orphan per entity name.

In `@packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts`:
- Around line 378-404: Remove the unnecessary annotationNamespace empty-string
validation from contractNamespaceToSchemaIR, since this function does not use
annotationNamespace at all. Keep the rest of the namespace-to-schema conversion
logic intact in contractNamespaceToSchemaIR, and leave annotationNamespace
validation only in the path where it is actually consumed, such as
contractToSchemaIR.
- Around line 378-451: Both `contractNamespaceToSchemaIR` and
`contractToSchemaIR` duplicate the same storage-type setup and table conversion
logic, so refactor to reuse the namespace-level conversion path instead of
maintaining two loops. Make `contractToSchemaIR` delegate per namespace to
`contractNamespaceToSchemaIR` or extract the shared
`assertStorageTable`/`convertTable` iteration into a helper, while keeping the
cross-namespace duplicate-table guard and `deriveAnnotations` only in
`contractToSchemaIR`. This keeps the behavior in sync and avoids drift between
`contractNamespaceToSchemaIR`, `contractToSchemaIR`, and `convertTable`.

In `@packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts`:
- Around line 556-586: The introspection flow is doing a redundant database-wide
Postgres version lookup inside each namespace pass. Hoist the version fetch out
of `introspect()` and `introspectSchema()` so `getPostgresVersion(driver)` runs
once per `introspect` call, then pass the single version through to
`PostgresDatabaseSchemaNode`; update `introspectSchema` to stop returning
`pgVersion` and remove any per-namespace version query usage.

---

Duplicate comments:
In `@packages/2-sql/9-family/src/core/control-instance.ts`:
- Around line 972-995: `toSchemaView` still drops namespace identity when
flattening schema tables, causing ID collisions for same-named tables across
namespaces. Update the table flattening in `toSchemaView` so each entry carries
its namespace-qualified key (or equivalent unique table identifier), then use
that qualified value when generating `SchemaTreeNode` IDs and labels in the
table, column, primary-key, unique, and index node creation paths. Keep the
existing structure of `tableRecords`/`tableEntries`, but thread the
namespace-qualified identifier through the later mappings instead of reusing
bare `tableName`.
- Around line 722-752: In verifySchema, the returned sqlResult can keep stale
ok/code/summary values after filterSchemaDiffIssues removes all structural
issues, because diffDatabaseSchema was computed before control-policy
suppression. Update the VerifySchema path to recompute the result status from
the filtered schemaDiffIssues and relationalFails whenever the filtered list
differs from sqlResult.schema.schemaDiffIssues, including the zero-issue case,
so the returned schema summary matches the post-filter counts.

In `@packages/2-sql/9-family/src/core/migrations/types.ts`:
- Around line 509-515: `DiffDatabaseSchemaInput` is missing the adapter
normalization hooks needed by schema diffing. Add `normalizeDefault` and
`normalizeNativeType` to `DiffDatabaseSchemaInput`, then thread them from the
relevant `SqlControlAdapter` into
`diffDatabaseSchema`/`diffPostgresDatabaseSchema` call sites such as
`PostgresMigrationPlanner.planSql` and the verify path. Update the
`diffDatabaseSchema` implementations for Postgres and SQLite to use these hooks
when comparing defaults/native types, matching the existing behavior in
`verifySqlSchema` and `verifySqlSchemaTree`.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts`:
- Around line 97-99: Update PostgresTableSchemaNode.isEqualTo to mirror the
kind-checking pattern used in PostgresPolicySchemaNode.isEqualTo: verify the
other node is actually a PostgresTableSchemaNode before comparing ids, then keep
the identity-based id comparison only after that guard. This keeps equality
consistent with the schema node design and avoids treating different node kinds
as equal when ids collide.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e68eb10-1603-4fa2-b4c5-0e06d57d7e95

📥 Commits

Reviewing files that changed from the base of the PR and between e12408f and 833e054.

📒 Files selected for processing (88)

• packages/1-framework/1-core/framework-components/src/control/control-instances.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-run.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-verify.ts
• packages/1-framework/3-tooling/cli/test/config-types.test.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner-types.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner.ts
• packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts
• packages/1-framework/3-tooling/migration/src/aggregate/strategies/synth.ts
• packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts
• packages/1-framework/3-tooling/migration/src/exports/aggregate.ts
• packages/1-framework/3-tooling/migration/test/aggregate/planner.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/project-schema-to-space.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/strategies/synth.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/verifier.test.ts
• packages/1-framework/3-tooling/migration/test/deletable-node-modules.test.ts
• packages/2-mongo-family/9-family/src/core/control-instance.ts
• packages/2-mongo-family/9-family/src/core/schema-shape.ts
• packages/2-mongo-family/9-family/src/exports/control.ts
• packages/2-mongo-family/9-family/test/schema-shape.test.ts
• packages/2-sql/1-core/contract/src/exports/types.ts
• packages/2-sql/1-core/contract/src/ir/storage-table.ts
• packages/2-sql/1-core/contract/src/types.ts
• packages/2-sql/1-core/schema-ir/src/exports/types.ts
• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir-node.ts
• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir.ts
• packages/2-sql/1-core/schema-ir/src/types.ts
• packages/2-sql/9-family/package.json
• packages/2-sql/9-family/src/core/control-adapter.ts
• packages/2-sql/9-family/src/core/control-instance.ts
• packages/2-sql/9-family/src/core/diff/control-verify-emit.ts
• packages/2-sql/9-family/src/core/diff/schema-shape.ts
• packages/2-sql/9-family/src/core/diff/sql-schema-diff.ts
• packages/2-sql/9-family/src/core/diff/verifier-disposition.ts
• packages/2-sql/9-family/src/core/diff/verify-helpers.ts
• packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts
• packages/2-sql/9-family/src/core/migrations/types.ts
• packages/2-sql/9-family/src/core/psl-contract-infer/printer-config.ts
• packages/2-sql/9-family/src/exports/diff.ts
• packages/2-sql/9-family/src/exports/schema-verify.ts
• packages/2-sql/9-family/test/control-instance.descriptor-self-consistency.test.ts
• packages/2-sql/9-family/test/cross-contract-validation.test.ts
• packages/2-sql/9-family/test/operation-preview.test.ts
• packages/2-sql/9-family/test/schema-shape.test.ts
• packages/2-sql/9-family/test/schema-verify.basic.test.ts
• packages/2-sql/9-family/test/schema-verify.check-constraints.test.ts
• packages/2-sql/9-family/test/schema-verify.constraints.test.ts
• packages/2-sql/9-family/test/schema-verify.control-policy.test.ts
• packages/2-sql/9-family/test/schema-verify.defaults.test.ts
• packages/2-sql/9-family/test/schema-verify.helpers.ts
• packages/2-sql/9-family/test/schema-verify.referential-actions.test.ts
• packages/2-sql/9-family/test/schema-verify.semantic-satisfaction.test.ts
• packages/2-sql/9-family/test/schema-verify.storage-types.test.ts
• packages/2-sql/9-family/test/schema-verify.strict.test.ts
• packages/2-sql/9-family/test/schema-view.test.ts
• packages/2-sql/9-family/test/verifier-disposition.test.ts
• packages/2-sql/9-family/tsdown.config.ts
• packages/3-mongo-target/1-mongo-target/src/core/control-target.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-postgres-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/issue-planner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/resolve-ddl-schema.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-role-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/schema-node-kinds.ts
• packages/3-targets/3-targets/postgres/src/exports/control.ts
• packages/3-targets/3-targets/postgres/src/exports/schema-ir-annotations.ts
• packages/3-targets/3-targets/postgres/test/migrations/contract-to-postgres-database-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/migrations/diff-postgres-schema.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-database-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-namespace-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-table-schema-node.test.ts
• packages/3-targets/3-targets/sqlite/src/core/control-target.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/planner.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/runner.ts
• packages/3-targets/6-adapters/postgres/src/core/control-adapter.ts
• packages/3-targets/6-adapters/postgres/test/migrations/array-column-introspection.integration.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-collect-extension-issues.test.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-migration-plan.integration.test.ts
• projects/postgres-rls/slices/schema-node-tree-restructure/design-diff-and-verify.md
• test/e2e/framework/test/sqlite/migrations/harness.ts
• test/integration/test/family.introspect.integration.test.ts
• test/integration/test/family.introspect.test.ts

💤 Files with no reviewable changes (4)

• packages/3-targets/3-targets/postgres/src/core/migrations/resolve-ddl-schema.ts
• packages/2-sql/9-family/src/exports/schema-verify.ts
• packages/2-sql/1-core/schema-ir/src/exports/types.ts
• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir.ts

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Duplicate projectSchemaToMember wrapping across CLI operations.

The same blindCast-wrapped delegation to familyInstance.projectSchemaToMember appears here and in db-verify.ts (Lines 119-126). Consider extracting a small shared helper (e.g., in a common CLI control-api util) that both operations call, to avoid re-deriving the cast/comment each time.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/cli/src/control-api/operations/db-run.ts`
around lines 188 - 195, The duplicated `projectSchemaToMember` delegation in
`db-run.ts` and `db-verify.ts` should be factored into a shared CLI helper
instead of repeating the same `blindCast` wrapper and comment. Extract a small
utility in a common control-api/CLI module that accepts the schema and
`ownedByOtherNames`, performs the `familyInstance.projectSchemaToMember` call,
and reuse it from both operations to keep the cast and opaque-schema
justification in one place.

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

isEqualTo skips type validation, unlike PostgresRoleSchemaNode.

isEqualTo here only checks this.id === other.id with no nodeKind check, while PostgresRoleSchemaNode.isEqualTo validates the compared node's kind and throws on mismatch. Given children() only ever yields namespace nodes for this root, cross-type comparisons shouldn't currently occur, but the asymmetry could mask a bug if the tree shape changes later.

♻️ Optional consistency fix

   isEqualTo(other: DiffableNode): boolean {
-    return this.id === other.id;
+    const node = blindCast<SqlSchemaIRNode, 'diff-tree pairing guarantees a SqlSchemaIRNode'>(other);
+    return PostgresDatabaseSchemaNode.is(node) && this.id === node.id;
   }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	isEqualTo(other: DiffableNode): boolean {
	return this.id === other.id;
	}
	isEqualTo(other: DiffableNode): boolean {
	const node = blindCast<SqlSchemaIRNode, 'diff-tree pairing guarantees a SqlSchemaIRNode'>(other);
	return PostgresDatabaseSchemaNode.is(node) && this.id === node.id;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-database-schema-node.ts`
around lines 68 - 70, Update PostgresDatabaseSchemaNode.isEqualTo to match the
stricter comparison behavior used by PostgresRoleSchemaNode: validate that the
other DiffableNode is the expected node kind before comparing ids, and throw or
otherwise fail on mismatched kinds instead of returning a false positive. Keep
the comparison logic within isEqualTo consistent with the nodeKind-based guard
already used elsewhere so future tree-shape changes do not hide cross-type
comparisons.

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Same isEqualTo type-validation gap as PostgresDatabaseSchemaNode.

Compares only id without confirming other is actually a PostgresNamespaceSchemaNode, unlike PostgresRoleSchemaNode.isEqualTo. Low risk today since children() on the database root only yields namespace nodes, but flagging for consistency with the stricter pattern used elsewhere.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts`
around lines 54 - 56, The `isEqualTo` implementation on
`PostgresNamespaceSchemaNode` only compares `id` and does not verify that
`other` is the same node type. Update this method to first check that `other` is
a `PostgresNamespaceSchemaNode`, following the stricter pattern used by
`PostgresRoleSchemaNode.isEqualTo`, and only then compare identifiers.

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Kind-check in isEqualTo is inconsistent with sibling nodes.

This is the only node (table/namespace/database don't) that validates other.nodeKind before comparing by id, throwing if mismatched. Sibling isEqualTo implementations do a bare this.id === other.id. Given the tree only ever pairs same-kind nodes structurally, this extra check is likely unreachable in practice, but the asymmetry is worth aligning for consistency (either add the same guard everywhere, or drop it here).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts`
around lines 73 - 84, The PostgresPolicySchemaNode.isEqualTo implementation is
the only sibling that performs an explicit kind check before comparing ids,
making it inconsistent with the other schema nodes. Align it with the other
isEqualTo methods in the same diff by either removing the
PostgresPolicySchemaNode.is(node) guard and relying on the id comparison like
the table/namespace/database nodes, or applying the same kind validation pattern
consistently across all sibling nodes.

[wmadden]

Better but still some work to do

[coderabbitai]

Actionable comments posted: 3

♻️ Duplicate comments (2)

packages/2-sql/9-family/src/core/control-instance.ts (2)

735-739: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Recompute ok after filtering structural diff issues.

When all schemaDiffIssues are suppressed, this branch can still return the original failed sqlResult, leaving verify failed with no surviving structural issues. Recompute the total failure count after filtering and set ok from that value.

Proposed fix

       const schemaDiffIssues = filterSchemaDiffIssues(
         sqlResult.schema.schemaDiffIssues,
         contract.defaultControlPolicy,
       );
       const relationalFails = sqlResult.schema.counts.fail;
-      if (schemaDiffIssues.length === 0) {
-        if (schemaDiffIssues === sqlResult.schema.schemaDiffIssues) return sqlResult;
-        return { ...sqlResult, schema: { ...sqlResult.schema, schemaDiffIssues } };
-      }
       const totalFails = relationalFails + schemaDiffIssues.length;
+      if (totalFails === 0) {
+        return {
+          ...sqlResult,
+          ok: true,
+          summary: 'Database schema satisfies contract',
+          schema: {
+            ...sqlResult.schema,
+            schemaDiffIssues,
+            counts: { ...sqlResult.schema.counts, fail: 0 },
+          },
+        };
+      }
       return {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-instance.ts` around lines 735 - 739,
In control-instance.ts, the branch that returns sqlResult after filtering
schemaDiffIssues can leave ok stale when all structural issues are removed.
Update the logic around the schemaDiffIssues handling to recompute the failure
count from the filtered issues and derive ok from that updated count before
returning sqlResult, so verify doesn’t stay failed with no remaining structural
issues.

---

960-967: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Carry namespace identity into schema-view table entries.

Flattening to [tableName, table] still collides for public.users and auth.users; child IDs also use only tableName. Include the namespace in the flattened entry and derive IDs/labels from the qualified name.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/control-instance.ts` around lines 960 - 967,
The schema-view table flattening in control-instance currently drops namespace
identity, so tables with the same name in different namespaces can collide.
Update the table entry निर्माण in the schema tree logic to carry the namespace
alongside each table when building tableEntries from
root.namespaces/root.tables, and then use that qualified namespace+table name in
the tableNodes mapping for IDs and labels. Make sure the relevant schema-tree
construction in control-instance distinguishes entries by fully qualified name
instead of only tableName.

🧹 Nitpick comments (2)

packages/1-framework/3-tooling/migration/test/aggregate/scope-schema-result.test.ts (1)

172-184: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

This test won't catch a stale code leak.

resultWith() never populates code, so expect(scoped.code).toBeUndefined() passes trivially regardless of whether scopeSchemaResultToSpace actually clears a pre-existing failure code. Consider adding a case where the input result has code: 'PN-RUN-3010' set alongside ok: false, and asserting it's cleared once scoping flips ok to true.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/1-framework/3-tooling/migration/test/aggregate/scope-schema-result.test.ts`
around lines 172 - 184, The scopeSchemaResultToSpace test currently cannot
detect a stale code being carried through when siblings are removed. Update the
test around scopeSchemaResultToSpace and resultWith to use an input result with
an existing failure code such as PN-RUN-3010 alongside ok: false, then verify
that after scoping to the sibling space the result flips to ok: true and clears
code to undefined while preserving the recomputed summary.

packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts (1)

83-106: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Root status is recomputed even when nothing was dropped.

pruneTopLevelTables always recomputes root.status from aggregateStatus(kept), even when dropped.length === 0. If the framework's real root-status computation ever depends on something beyond simple child aggregation (e.g. a namespace-level condition not represented as a top-level child), this could produce a spurious status flip on a true no-op call, which countsAfterDrop would then (incorrectly) adjust for since it only checks newRootStatus !== oldRootStatus, not whether anything was actually dropped.

Guarding the no-op case would remove this risk cheaply.

♻️ Proposed fix

   return {
-    root: { ...root, status: aggregateStatus(kept), children: kept },
-    dropped,
+    root: dropped.length === 0 ? root : { ...root, status: aggregateStatus(kept), children: kept },
+    dropped,
   };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts`
around lines 83 - 106, In pruneTopLevelTables, avoid recomputing and replacing
root.status when nothing was dropped. Keep the existing root status unchanged
for the no-op path, and only derive a new status from aggregateStatus(kept) when
dropped has entries. This prevents countsAfterDrop from seeing a status change
on an unchanged tree and incorrectly adjusting counts based on
nodeEntityName/isEntityNode handling.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts`:
- Around line 56-61: The helper schemaDiffIssueEntityName currently uses a raw
TypeScript cast to read tableName from actual, which violates the no-bare-as
guideline. Update this logic to use the approved cast helper from
`@prisma-next/utils/casts`, such as castAs or blindCast with a clear reason, while
keeping the same undefined handling and string check in
schemaDiffIssueEntityName.
- Around line 189-195: The scoped result builder in scope-schema-result should
clear any stale failure code when `ok` flips to `true`, since the current spread
in the return object preserves `result.code` from the incoming value. Update the
return construction so `code` is explicitly removed or set to undefined/null
whenever `ok` is true, and only retain `result.code` (or the default
`PN-RUN-3010`) in the failing branch. Use the `ok` calculation and the final
object assembly in the same return path to ensure consumers of
`scopeSchemaResult` never see `ok: true` paired with a failure `code`.

In `@packages/2-sql/9-family/src/core/migrations/scope-plan-diff.ts`:
- Around line 1-12: The issue is the bare type assertion in issueEntityName,
where actual is cast directly before reading tableName. Replace that inline cast
with the approved helper (blindCast<T, "Reason"> or castAs<T>) and keep the
narrowing as tight as possible so the function still returns the table name only
when it is actually a string.

---

Duplicate comments:
In `@packages/2-sql/9-family/src/core/control-instance.ts`:
- Around line 735-739: In control-instance.ts, the branch that returns sqlResult
after filtering schemaDiffIssues can leave ok stale when all structural issues
are removed. Update the logic around the schemaDiffIssues handling to recompute
the failure count from the filtered issues and derive ok from that updated count
before returning sqlResult, so verify doesn’t stay failed with no remaining
structural issues.
- Around line 960-967: The schema-view table flattening in control-instance
currently drops namespace identity, so tables with the same name in different
namespaces can collide. Update the table entry निर्माण in the schema tree logic
to carry the namespace alongside each table when building tableEntries from
root.namespaces/root.tables, and then use that qualified namespace+table name in
the tableNodes mapping for IDs and labels. Make sure the relevant schema-tree
construction in control-instance distinguishes entries by fully qualified name
instead of only tableName.

---

Nitpick comments:
In
`@packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts`:
- Around line 83-106: In pruneTopLevelTables, avoid recomputing and replacing
root.status when nothing was dropped. Keep the existing root status unchanged
for the no-op path, and only derive a new status from aggregateStatus(kept) when
dropped has entries. This prevents countsAfterDrop from seeing a status change
on an unchanged tree and incorrectly adjusting counts based on
nodeEntityName/isEntityNode handling.

In
`@packages/1-framework/3-tooling/migration/test/aggregate/scope-schema-result.test.ts`:
- Around line 172-184: The scopeSchemaResultToSpace test currently cannot detect
a stale code being carried through when siblings are removed. Update the test
around scopeSchemaResultToSpace and resultWith to use an input result with an
existing failure code such as PN-RUN-3010 alongside ok: false, then verify that
after scoping to the sibling space the result flips to ok: true and clears code
to undefined while preserving the recomputed summary.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9e832c4f-7c0a-4ead-82cf-154f19624fca

📥 Commits

Reviewing files that changed from the base of the PR and between 833e054 and 2ae324e.

⛔ Files ignored due to path filters (1)

• projects/postgres-rls/slices/schema-node-tree-restructure/design-diff-and-verify.md is excluded by !projects/**

📒 Files selected for processing (64)

• packages/1-framework/1-core/framework-components/src/control/control-instances.ts
• packages/1-framework/1-core/framework-components/src/control/control-migration-types.ts
• packages/1-framework/1-core/framework-components/src/control/schema-diff.ts
• packages/1-framework/1-core/framework-components/src/exports/control.ts
• packages/1-framework/1-core/framework-components/test/schema-diff.test.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-verify.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner-types.ts
• packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts
• packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts
• packages/1-framework/3-tooling/migration/src/aggregate/strategies/synth.ts
• packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts
• packages/1-framework/3-tooling/migration/src/exports/aggregate.ts
• packages/1-framework/3-tooling/migration/test/aggregate/project-schema-to-space.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/scope-schema-result.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/strategies/synth.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/verifier.test.ts
• packages/1-framework/3-tooling/migration/test/deletable-node-modules.test.ts
• packages/2-sql/1-core/contract/src/exports/types.ts
• packages/2-sql/1-core/contract/src/ir/storage-table.ts
• packages/2-sql/1-core/contract/src/types.ts
• packages/2-sql/9-family/src/core/control-instance.ts
• packages/2-sql/9-family/src/core/diff/sql-schema-diff.ts
• packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts
• packages/2-sql/9-family/src/core/migrations/field-event-planner.ts
• packages/2-sql/9-family/src/core/migrations/schema-differ.ts
• packages/2-sql/9-family/src/core/migrations/scope-plan-diff.ts
• packages/2-sql/9-family/src/core/migrations/types.ts
• packages/2-sql/9-family/src/core/psl-contract-infer/printer-config.ts
• packages/2-sql/9-family/src/exports/control.ts
• packages/2-sql/9-family/src/exports/diff.ts
• packages/2-sql/9-family/test/control-instance.descriptor-self-consistency.test.ts
• packages/2-sql/9-family/test/cross-contract-validation.test.ts
• packages/2-sql/9-family/test/namespace-hydration.test.ts
• packages/2-sql/9-family/test/operation-preview.test.ts
• packages/2-sql/9-family/test/schema-verify.helpers.ts
• packages/2-sql/9-family/test/schema-view.test.ts
• packages/3-mongo-target/1-mongo-target/src/core/control-target.ts
• packages/3-mongo-target/1-mongo-target/src/core/mongo-runner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-postgres-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/resolve-ddl-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/runner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/verify-postgres-namespaces.ts
• packages/3-targets/3-targets/postgres/src/core/postgres-rls-policy.ts
• packages/3-targets/3-targets/postgres/src/core/psl-infer/infer-psl-contract.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-namespace-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-role-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-table-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/schema-node-kinds.ts
• packages/3-targets/3-targets/postgres/src/exports/control.ts
• packages/3-targets/3-targets/postgres/src/exports/planner.ts
• packages/3-targets/3-targets/postgres/src/exports/types.ts
• packages/3-targets/3-targets/postgres/test/migrations/diff-database-schema.test.ts
• packages/3-targets/3-targets/postgres/test/postgres-database-schema-node.test.ts
• packages/3-targets/3-targets/postgres/test/rls-diffable-nodes.test.ts
• packages/3-targets/3-targets/sqlite/src/core/control-target.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/planner.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/runner.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-collect-extension-issues.test.ts

💤 Files with no reviewable changes (10)

• packages/3-targets/3-targets/postgres/src/exports/planner.ts
• packages/3-targets/3-targets/postgres/test/postgres-database-schema-node.test.ts
• packages/2-sql/9-family/src/exports/diff.ts
• packages/2-sql/1-core/contract/src/exports/types.ts
• packages/2-sql/9-family/src/core/psl-contract-infer/printer-config.ts
• packages/3-targets/3-targets/postgres/src/exports/types.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-postgres-schema.ts
• packages/1-framework/3-tooling/migration/src/aggregate/project-schema-to-space.ts
• packages/3-targets/3-targets/postgres/src/core/postgres-rls-policy.ts
• packages/1-framework/3-tooling/migration/test/aggregate/project-schema-to-space.test.ts

✅ Files skipped from review due to trivial changes (5)

• packages/2-sql/9-family/test/operation-preview.test.ts
• packages/1-framework/1-core/framework-components/src/control/control-instances.ts
• packages/2-sql/9-family/src/core/migrations/schema-differ.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner-types.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-verify.ts

🚧 Files skipped from review as they are similar to previous changes (19)

• packages/3-targets/3-targets/postgres/src/core/schema-ir/schema-node-kinds.ts
• packages/2-sql/9-family/test/schema-view.test.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/verify-postgres-namespaces.ts
• packages/2-sql/9-family/test/cross-contract-validation.test.ts
• packages/2-sql/9-family/test/control-instance.descriptor-self-consistency.test.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-role-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/resolve-ddl-schema.ts
• packages/3-targets/3-targets/postgres/src/exports/control.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/contract-to-postgres-database-schema-node.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/postgres-policy-schema-node.ts
• packages/2-sql/9-family/src/core/migrations/contract-to-schema-ir.ts
• packages/3-targets/3-targets/postgres/src/core/psl-infer/infer-psl-contract.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/runner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/runner.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts
• packages/2-sql/9-family/src/core/diff/sql-schema-diff.ts
• packages/3-targets/6-adapters/postgres/test/migrations/rls-collect-extension-issues.test.ts
• packages/3-targets/3-targets/sqlite/src/core/control-target.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/planner.ts

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Bare as cast in production code.

(actual as { readonly tableName?: unknown }).tableName is a raw as cast. As per coding guidelines: "No bare as in production code. Use blindCast<T, \"Reason\"> or castAs<T> from @prisma-next/utils/casts... as const and test files are exempt."

♻️ Proposed fix

-  const name = (actual as { readonly tableName?: unknown }).tableName;
+  const name = castAs<{ readonly tableName?: unknown }>(actual).tableName;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	function schemaDiffIssueEntityName(issue: SchemaDiffIssue): string | undefined {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const name = (actual as { readonly tableName?: unknown }).tableName;
	return typeof name === 'string' ? name : undefined;
	}
	function schemaDiffIssueEntityName(issue: SchemaDiffIssue): string | undefined {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const name = castAs<{ readonly tableName?: unknown }>(actual).tableName;
	return typeof name === 'string' ? name : undefined;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts`
around lines 56 - 61, The helper schemaDiffIssueEntityName currently uses a raw
TypeScript cast to read tableName from actual, which violates the no-bare-as
guideline. Update this logic to use the approved cast helper from
`@prisma-next/utils/casts`, such as castAs or blindCast with a clear reason, while
keeping the same undefined handling and string check in
schemaDiffIssueEntityName.

Source: Coding guidelines

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Stale failure code can survive a flip to ok: true.

When ok becomes true (all failures were sibling-owned), the spread order leaves result.code untouched — it's only ever set (not cleared) when !ok. If the incoming result had code set (typical when the pre-scope result was ok: false), the scoped result ends up ok: true with a stale failure code, which is an inconsistent state that any consumer branching on code would misinterpret.

🐛 Proposed fix

+  const { code: _staleCode, ...resultWithoutCode } = result;
   return {
-    ...result,
+    ...resultWithoutCode,
     ok,
     ...(ok ? {} : { code: result.code ?? 'PN-RUN-3010' }),
     summary: ok ? 'Database schema satisfies contract' : result.summary,
     schema: { issues, schemaDiffIssues, root, counts },
   };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	return {
	...result,
	ok,
	...(ok ? {} : { code: result.code ?? 'PN-RUN-3010' }),
	summary: ok ? 'Database schema satisfies contract' : result.summary,
	schema: { issues, schemaDiffIssues, root, counts },
	};
	const { code: _staleCode, ...resultWithoutCode } = result;
	return {
	...resultWithoutCode,
	ok,
	...(ok ? {} : { code: result.code ?? 'PN-RUN-3010' }),
	summary: ok ? 'Database schema satisfies contract' : result.summary,
	schema: { issues, schemaDiffIssues, root, counts },
	};

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/1-framework/3-tooling/migration/src/aggregate/scope-schema-result.ts`
around lines 189 - 195, The scoped result builder in scope-schema-result should
clear any stale failure code when `ok` flips to `true`, since the current spread
in the return object preserves `result.code` from the incoming value. Update the
return construction so `code` is explicitly removed or set to undefined/null
whenever `ok` is true, and only retain `result.code` (or the default
`PN-RUN-3010`) in the failing branch. Use the `ok` calculation and the final
object assembly in the same return path to ensure consumers of
`scopeSchemaResult` never see `ok: true` paired with a failure `code`.

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Bare as cast in production code.

(actual as { readonly tableName?: unknown }).tableName is a bare cast. Per coding guidelines, production code must use blindCast<T, "Reason"> (or castAs<T>) instead, narrowed as far as possible.

♻️ Proposed fix

+import { blindCast } from '`@prisma-next/utils/casts`';
+
 function issueEntityName(issue: DiffIssue): string | undefined {
   if ('outcome' in issue) {
     const actual = issue.actual;
     if (actual === undefined) return undefined;
-    const tableName = (actual as { readonly tableName?: unknown }).tableName;
+    const tableName = blindCast<
+      { readonly tableName?: unknown },
+      'DiffableNode may expose tableName for table-shaped nodes'
+    >(actual).tableName;
     return typeof tableName === 'string' ? tableName : undefined;
   }
   return 'table' in issue ? issue.table : undefined;
 }

As per coding guidelines, "No bare as in production code. Use blindCast<T, "Reason"> or castAs<T>".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	import type { DiffIssue, SchemaDiff } from '@prisma-next/framework-components/control';
	/** The entity name a diff issue addresses, for ownership scoping. */
	function issueEntityName(issue: DiffIssue): string | undefined {
	if ('outcome' in issue) {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const tableName = (actual as { readonly tableName?: unknown }).tableName;
	return typeof tableName === 'string' ? tableName : undefined;
	}
	return 'table' in issue ? issue.table : undefined;
	}
	import type { DiffIssue, SchemaDiff } from '`@prisma-next/framework-components/control`';
	import { blindCast } from '`@prisma-next/utils/casts`';
	/** The entity name a diff issue addresses, for ownership scoping. */
	function issueEntityName(issue: DiffIssue): string | undefined {
	if ('outcome' in issue) {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const tableName = blindCast<
	{ readonly tableName?: unknown },
	'DiffableNode may expose tableName for table-shaped nodes'
	>(actual).tableName;
	return typeof tableName === 'string' ? tableName : undefined;
	}
	return 'table' in issue ? issue.table : undefined;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/2-sql/9-family/src/core/migrations/scope-plan-diff.ts` around lines
1 - 12, The issue is the bare type assertion in issueEntityName, where actual is
cast directly before reading tableName. Replace that inline cast with the
approved helper (blindCast<T, "Reason"> or castAs<T>) and keep the narrowing as
tight as possible so the function still returns the table name only when it is
actually a string.

Source: Coding guidelines

[coderabbitai]

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/1-framework/3-tooling/cli/src/commands/db-verify.ts`:
- Around line 545-556: Schema-only verification can exit with no diagnostics
when `--quiet` is set because `handleResult`’s callback in `db-verify.ts` passes
`flags` straight into `formatSchemaVerifyOutput`, which suppresses output for
quiet mode. Update the schema-only success path to mirror the full-mode failure
branch by forcing a non-quiet flags object before calling
`formatSchemaVerifyOutput`, using the existing `flags`, `handleResult`, and
`formatSchemaVerifyOutput` flow so `--schema-only --quiet` still prints the
failure details.

In `@packages/1-framework/3-tooling/cli/src/utils/combine-verify-results.ts`:
- Around line 73-81: The summary logic in combineVerifyResults uses a bare cast
on firstFailure, which violates the production casting guideline. Replace the
`(firstFailure as VerifyDatabaseSchemaResult).summary` access with a safe cast
helper from `@prisma-next/utils/casts`, using blindCast or castAs with a short
reason that documents the okAll/appResult.ok invariant. Keep the existing
branching in combineVerifyResults unchanged and apply the cast only where
firstFailure is read.

In `@packages/1-framework/3-tooling/migration/src/aggregate/aggregate.ts`:
- Around line 241-263: The namespace collection logic in
collectAggregateNamespaces currently overwrites same-key entries with
last-write-wins, which can drop earlier tables from shared namespaceIds. Update
the aggregation in collectAggregateNamespaces to merge namespace contents per
key instead of assigning merged[key] = ns, or explicitly detect and reject
incompatible namespace shapes before building the object passed to
familyInstance.introspect. Keep the fix localized to collectAggregateNamespaces
and its merged namespace accumulation.

In
`@packages/1-framework/3-tooling/migration/src/aggregate/unclaimed-elements.ts`:
- Around line 30-36: The helper schemaDiffIssueEntityName still uses a bare cast
to read tableName from issue.actual, which violates the production casting
guideline. Update this function to match the pattern used by issueEntityName in
strategies/synth.ts by replacing the inline as cast with blindCast from
`@prisma-next/utils/casts`, while keeping the same undefined and string checks for
the extracted name.

In `@packages/3-mongo-target/1-mongo-target/src/core/scope-verify-result.ts`:
- Around line 61-80: The countTree helper is currently including the synthetic
root in its pass/warn/fail/totalNodes totals, which makes the recomputed
verification counts off by one. Update countTree in scope-verify-result.ts to
traverse and count only node.children from the provided root instead of visiting
the root itself, while keeping the existing counting logic for
SchemaVerificationNode statuses unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: eed8a146-92f6-4958-9a3a-d6082bf60d11

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae324e and 9d56e8e.

⛔ Files ignored due to path filters (1)

• projects/postgres-rls/slices/schema-node-tree-restructure/design-diff-and-verify.md is excluded by !projects/**

📒 Files selected for processing (63)

• docs/architecture docs/subsystems/7. Migration System.md
• packages/1-framework/1-core/framework-components/src/control/control-migration-types.ts
• packages/1-framework/1-core/framework-components/src/control/schema-diff.ts
• packages/1-framework/3-tooling/cli/src/commands/db-verify.ts
• packages/1-framework/3-tooling/cli/src/commands/migrate.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-check.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-graph.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-list.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-plan.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-status.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-init.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-run.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-verify.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/migrate.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/run-migration.ts
• packages/1-framework/3-tooling/cli/src/control-api/types.ts
• packages/1-framework/3-tooling/cli/src/utils/combine-schema-results.ts
• packages/1-framework/3-tooling/cli/src/utils/combine-verify-results.ts
• packages/1-framework/3-tooling/cli/src/utils/extension-pack-inputs.ts
• packages/1-framework/3-tooling/cli/src/utils/formatters/verify.ts
• packages/1-framework/3-tooling/cli/src/utils/plan-resolution.ts
• packages/1-framework/3-tooling/cli/test/commands/migrate-show.test.ts
• packages/1-framework/3-tooling/cli/test/commands/migration-plan-command.test.ts
• packages/1-framework/3-tooling/cli/test/commands/migration-read-commands-parity.test.ts
• packages/1-framework/3-tooling/cli/test/control-api/apply.test.ts
• packages/1-framework/3-tooling/cli/test/control-api/db-verify.per-space-verifier.test.ts
• packages/1-framework/3-tooling/cli/test/utils/combine-verify-results.test.ts
• packages/1-framework/3-tooling/cli/test/utils/plan-resolution.test.ts
• packages/1-framework/3-tooling/migration/src/aggregate/aggregate.ts
• packages/1-framework/3-tooling/migration/src/aggregate/check-integrity.ts
• packages/1-framework/3-tooling/migration/src/aggregate/loader.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner-types.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner.ts
• packages/1-framework/3-tooling/migration/src/aggregate/strategies/graph-walk.ts
• packages/1-framework/3-tooling/migration/src/aggregate/strategies/synth.ts
• packages/1-framework/3-tooling/migration/src/aggregate/types.ts
• packages/1-framework/3-tooling/migration/src/aggregate/unclaimed-elements.ts
• packages/1-framework/3-tooling/migration/src/aggregate/verifier.ts
• packages/1-framework/3-tooling/migration/src/exports/aggregate.ts
• packages/1-framework/3-tooling/migration/src/gather-disk-contract-space-state.ts
• packages/1-framework/3-tooling/migration/src/integrity-violation.ts
• packages/1-framework/3-tooling/migration/src/verify-contract-spaces.ts
• packages/1-framework/3-tooling/migration/test/aggregate/check-integrity.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/contract-at.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/loader.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/planner.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/strategies/graph-walk.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/strategies/synth.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/unclaimed-elements.test.ts
• packages/1-framework/3-tooling/migration/test/aggregate/verifier.test.ts
• packages/1-framework/3-tooling/migration/test/deletable-node-modules.test.ts
• packages/1-framework/3-tooling/migration/test/fixtures.ts
• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir-node.ts
• packages/2-sql/9-family/src/core/migrations/types.ts
• packages/2-sql/9-family/src/exports/control.ts
• packages/3-extensions/supabase/test/classification.e2e.test.ts
• packages/3-mongo-target/1-mongo-target/src/core/control-target.ts
• packages/3-mongo-target/1-mongo-target/src/core/scope-verify-result.ts
• packages/3-mongo-target/1-mongo-target/test/scope-verify-result.test.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts
• packages/3-targets/3-targets/postgres/src/core/schema-ir/schema-node-kinds.ts
• packages/3-targets/3-targets/sqlite/src/core/migrations/planner.ts

💤 Files with no reviewable changes (2)

• packages/2-sql/9-family/src/exports/control.ts
• packages/1-framework/3-tooling/cli/src/utils/combine-schema-results.ts

✅ Files skipped from review due to trivial changes (13)

• packages/1-framework/3-tooling/cli/src/utils/extension-pack-inputs.ts
• packages/1-framework/3-tooling/migration/src/gather-disk-contract-space-state.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-init.ts
• packages/1-framework/3-tooling/migration/src/integrity-violation.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/db-run.ts
• packages/1-framework/3-tooling/cli/src/control-api/operations/run-migration.ts
• packages/1-framework/3-tooling/cli/src/commands/migration-graph.ts
• docs/architecture docs/subsystems/7. Migration System.md
• packages/3-extensions/supabase/test/classification.e2e.test.ts
• packages/1-framework/3-tooling/migration/src/aggregate/planner-types.ts
• packages/1-framework/3-tooling/cli/src/control-api/types.ts
• packages/1-framework/3-tooling/migration/test/aggregate/loader.test.ts
• packages/1-framework/3-tooling/migration/src/verify-contract-spaces.ts

🚧 Files skipped from review as they are similar to previous changes (4)

• packages/2-sql/1-core/schema-ir/src/ir/sql-schema-ir-node.ts
• packages/1-framework/3-tooling/migration/test/deletable-node-modules.test.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/diff-database-schema.ts
• packages/3-targets/3-targets/postgres/src/core/migrations/planner.ts

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Schema-only failures can exit silently under --quiet.

Unlike the full-mode failure branch below (Lines 583-591) which explicitly forces { ...flags, quiet: false } so that "exiting 1 without diagnostics is unhelpful" never happens, this schema-only success-callback passes flags unmodified into formatSchemaVerifyOutput. Since that formatter returns '' immediately when flags.quiet is true, running db verify --schema-only --quiet against a database that fails schema verification will print nothing and simply exit with code 1 (via the result.ok && !result.value.result.ok check just below), leaving the user with no diagnostic output.

The line-range change summary for this segment describes "a forced quiet: false flags object," but the actual code doesn't apply that override here — only the full-mode failure path does.

🐛 Proposed fix to force diagnostics on schema-only failures

         const exitCode = handleResult(result, flags, ui, (combined) => {
           if (flags.json) {
             ui.output(formatSchemaVerifyJson(combined.result, combined.unclaimed));
           } else {
-            const output = formatSchemaVerifyOutput(combined.result, flags, combined.unclaimed);
+            const outputFlags = combined.result.ok ? flags : { ...flags, quiet: false };
+            const output = formatSchemaVerifyOutput(combined.result, outputFlags, combined.unclaimed);
             if (output) {
               ui.log(output);
             }
           }
         });

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const exitCode = handleResult(result, flags, ui, (combined) => {
	if (flags.json) {
	ui.output(formatSchemaVerifyJson(schemaVerifyResult));
	ui.output(formatSchemaVerifyJson(combined.result, combined.unclaimed));
	} else {
	const output = formatSchemaVerifyOutput(schemaVerifyResult, flags);
	const output = formatSchemaVerifyOutput(combined.result, flags, combined.unclaimed);
	if (output) {
	ui.log(output);
	}
	}
	});
	if (result.ok && !result.value.ok) {
	if (result.ok && !result.value.result.ok) {
	const exitCode = handleResult(result, flags, ui, (combined) => {
	if (flags.json) {
	ui.output(formatSchemaVerifyJson(combined.result, combined.unclaimed));
	} else {
	const outputFlags = combined.result.ok ? flags : { ...flags, quiet: false };
	const output = formatSchemaVerifyOutput(combined.result, outputFlags, combined.unclaimed);
	if (output) {
	ui.log(output);
	}
	}
	});
	if (result.ok && !result.value.result.ok) {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/cli/src/commands/db-verify.ts` around lines
545 - 556, Schema-only verification can exit with no diagnostics when `--quiet`
is set because `handleResult`’s callback in `db-verify.ts` passes `flags`
straight into `formatSchemaVerifyOutput`, which suppresses output for quiet
mode. Update the schema-only success path to mirror the full-mode failure branch
by forcing a non-quiet flags object before calling `formatSchemaVerifyOutput`,
using the existing `flags`, `handleResult`, and `formatSchemaVerifyOutput` flow
so `--schema-only --quiet` still prints the failure details.

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Bare as cast in production code.

(firstFailure as VerifyDatabaseSchemaResult).summary is a bare as cast on a non-test, non-as const production file. As per coding guidelines, **/*.{ts,tsx}: "No bare as in production code. Use blindCast<T, "Reason"> or castAs<T> from @prisma-next/utils/casts". The cast is logically safe (guarded by !okAll), so narrow it via blindCast with a short reason documenting the invariant.

♻️ Proposed fix

+import { blindCast } from '`@prisma-next/utils/casts`';
 import type { VerifyDatabaseSchemaResult } from '`@prisma-next/framework-components/control`';
...
   const summary = okAll
     ? unclaimedFails
       ? `Database schema has ${unclaimed.length} unclaimed element${unclaimed.length === 1 ? '' : 's'} (not in any contract)`
       : appResult.summary
     : appResult.ok
-      ? (firstFailure as VerifyDatabaseSchemaResult).summary
+      ? blindCast<
+          VerifyDatabaseSchemaResult,
+          'firstFailure is set whenever !okAll (some space failed)'
+        >(firstFailure).summary
       : appResult.summary;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	// Prefer a failing space's family phrasing; else, when only the unclaimed list
	// fails the verdict, say so; else keep the app space's phrasing.
	const summary = okAll
	? unclaimedFails
	? `Database schema has ${unclaimed.length} unclaimed element${unclaimed.length === 1 ? '' : 's'} (not in any contract)`
	: appResult.summary
	: appResult.ok
	? (firstFailure as VerifyDatabaseSchemaResult).summary
	: appResult.summary;
	// Prefer a failing space's family phrasing; else, when only the unclaimed list
	// fails the verdict, say so; else keep the app space's phrasing.
	const summary = okAll
	? unclaimedFails
	? `Database schema has ${unclaimed.length} unclaimed element${unclaimed.length === 1 ? '' : 's'} (not in any contract)`
	: appResult.summary
	: appResult.ok
	? blindCast<
	VerifyDatabaseSchemaResult,
	'firstFailure is set whenever !okAll (some space failed)'
	>(firstFailure).summary
	: appResult.summary;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/cli/src/utils/combine-verify-results.ts`
around lines 73 - 81, The summary logic in combineVerifyResults uses a bare cast
on firstFailure, which violates the production casting guideline. Replace the
`(firstFailure as VerifyDatabaseSchemaResult).summary` access with a safe cast
helper from `@prisma-next/utils/casts`, using blindCast or castAs with a short
reason that documents the okAll/appResult.ok invariant. Keep the existing
branching in combineVerifyResults unchanged and apply the cast only where
firstFailure is read.

Source: Coding guidelines

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check whether namespace-level (not just element-level) disjointness across spaces is enforced anywhere
rg -n -C3 'namespaceId' packages/1-framework/3-tooling/migration/src/aggregate/check-integrity.ts

Repository: prisma/prisma-next

Length of output: 633

---

🏁 Script executed:

#!/bin/bash
sed -n '200,310p' packages/1-framework/3-tooling/migration/src/aggregate/aggregate.ts
printf '\n---\n'
sed -n '180,260p' packages/1-framework/3-tooling/migration/src/aggregate/check-integrity.ts
printf '\n---\n'
rg -n -C3 'introspect\(|collectAggregateNamespaces|storage:\s*\{\s*namespaces' packages/1-framework/3-tooling/migration/src

Repository: prisma/prisma-next

Length of output: 8771

---

🏁 Script executed:

rg -n -C3 'type StorageNamespace|interface StorageNamespace|namespaceId|namespaces\s*:' packages/1-framework/3-tooling/migration/src packages/1-framework/3-tooling/migration -g '!**/dist/**'

Repository: prisma/prisma-next

Length of output: 18469

---

🏁 Script executed:

rg -n -C3 'collectAggregateNamespaces\(' packages/1-framework/3-tooling/migration/src packages/1-framework/3-tooling/migration/test

Repository: prisma/prisma-next

Length of output: 1001

---

🏁 Script executed:

rg -n -C3 'StorageNamespace|elementCoordinates\(|namespaceId|disjointness|unclaimed|extra' packages/1-framework/3-tooling/migration/src packages/1-framework/3-tooling/migration/test

Repository: prisma/prisma-next

Length of output: 50374

---

Merge namespace contents instead of replacing them

merged[key] = ns is last-write-wins. Spaces are allowed to share a namespaceId as long as their primitives are disjoint, so this can silently drop earlier tables from the object passed to familyInstance.introspect and skew the extra/unclaimed results. Merge the namespace entries (or reject conflicting namespace shapes) instead of overwriting the whole namespace.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/migration/src/aggregate/aggregate.ts` around
lines 241 - 263, The namespace collection logic in collectAggregateNamespaces
currently overwrites same-key entries with last-write-wins, which can drop
earlier tables from shared namespaceIds. Update the aggregation in
collectAggregateNamespaces to merge namespace contents per key instead of
assigning merged[key] = ns, or explicitly detect and reject incompatible
namespace shapes before building the object passed to familyInstance.introspect.
Keep the fix localized to collectAggregateNamespaces and its merged namespace
accumulation.

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Replace the bare as cast with blindCast.

Line 34 uses a bare as in production code to read the optional tableName off the diff node. The parallel helper issueEntityName in strategies/synth.ts already reads the same field via blindCast; mirror it here for consistency and guideline compliance.

Proposed fix

+import { blindCast } from '`@prisma-next/utils/casts`';
+
 /** The bare entity name an extra `SchemaDiffIssue` addresses, read off its actual (live-DB) node. */
 function schemaDiffIssueEntityName(issue: SchemaDiffIssue): string | undefined {
   const actual = issue.actual;
   if (actual === undefined) return undefined;
-  const name = (actual as { readonly tableName?: unknown }).tableName;
+  const name = blindCast<
+    { readonly tableName?: unknown },
+    'entity-name scoping reads the optional target-specific tableName off a diff node'
+  >(actual).tableName;
   return typeof name === 'string' ? name : undefined;
 }

As per coding guidelines: "No bare as in production code. Use blindCast<T, "Reason"> or castAs<T> from @prisma-next/utils/casts… as const and test files are exempt."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	/** The bare entity name an extra `SchemaDiffIssue` addresses, read off its actual (live-DB) node. */
	function schemaDiffIssueEntityName(issue: SchemaDiffIssue): string | undefined {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const name = (actual as { readonly tableName?: unknown }).tableName;
	return typeof name === 'string' ? name : undefined;
	}
	import { blindCast } from '`@prisma-next/utils/casts`';
	/** The bare entity name an extra `SchemaDiffIssue` addresses, read off its actual (live-DB) node. */
	function schemaDiffIssueEntityName(issue: SchemaDiffIssue): string | undefined {
	const actual = issue.actual;
	if (actual === undefined) return undefined;
	const name = blindCast<
	{ readonly tableName?: unknown },
	'entity-name scoping reads the optional target-specific tableName off a diff node'
	>(actual).tableName;
	return typeof name === 'string' ? name : undefined;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/1-framework/3-tooling/migration/src/aggregate/unclaimed-elements.ts`
around lines 30 - 36, The helper schemaDiffIssueEntityName still uses a bare
cast to read tableName from issue.actual, which violates the production casting
guideline. Update this function to match the pattern used by issueEntityName in
strategies/synth.ts by replacing the inline as cast with blindCast from
`@prisma-next/utils/casts`, while keeping the same undefined and string checks for
the extracted name.

Source: Coding guidelines

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

countTree should skip the synthetic root.
When scoping drops a node, this recomputation counts the root too, so pass/warn/fail/totalNodes end up off by one versus Mongo’s “root not counted” basis. Iterate over node.children instead.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/3-mongo-target/1-mongo-target/src/core/scope-verify-result.ts`
around lines 61 - 80, The countTree helper is currently including the synthetic
root in its pass/warn/fail/totalNodes totals, which makes the recomputed
verification counts off by one. Update countTree in scope-verify-result.ts to
traverse and count only node.children from the provided root instead of visiting
the root itself, while keeping the existing counting logic for
SchemaVerificationNode statuses unchanged.

[wmadden]

This is a weird inversion of control. Why not just give it the list of issues?

[wmadden]

WHAT THE FUCK IS THIS DOING IN THE FRAMEWORK DOMAIN

[wmadden]

This cannot live in the framework domain

[wmadden]

WTF

[wmadden]

wtf is "Part 2"

[wmadden]

No transient project ids

[wmadden]

Non optional