Skip to content

Conversation

zelosleone
Copy link
Contributor

@zelosleone zelosleone commented Aug 14, 2025

closes #7

will also close this one too hopefully: prefix-dev/rip#104

  • added serialize and deserialize features (thanks wolf) without any hardcoding into json, so that users can just do what they want (thanks Bas)
  • we already had human readable output that can be called via display_user_friendly function (damn i missed this, i feel too dumb)
  • users can just use whatever they want either display_user_friendly or serializable machine outputs with all the machine readable outputs into any format they want

@zelosleone zelosleone changed the title feat: add human and machine readable error output in json feat: add machine readable error output that can be serialized to any type Aug 18, 2025
@zelosleone zelosleone requested a review from baszalmstra August 18, 2025 21:25
@baszalmstra
Copy link
Contributor

@zelosleone I don't think the functionality of this PR is useful if it doesn't also include ecosystem-specific information. At the moment, the PR serializes IDs, which is completely useless because those IDs heavily depend on the implementation of the DependencyProvider and the Interner that created them at runtime.

It is also not enough to serialize the display strings because it would require parsing them back to ecosystem information, which is not trivial. Instead, the ecosystem provider should itself provide serialization for these fields, perhaps through another trait.

But even in the bigger picture, why is this useful? You link to a RIP issue, but don't you think it would be much more useful for that issue if the conflict were reduced to something that makes more sense for the consumption of downstream tools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support machine readable error message format (e.g. some struct that can be serialized to JSON)
2 participants