docs(proposals): add How? for pipeline info admin endpoint (#796) - #899
Open
henschwartz wants to merge 1 commit into
Open
docs(proposals): add How? for pipeline info admin endpoint (#796)#899henschwartz wants to merge 1 commit into
henschwartz wants to merge 1 commit into
Conversation
praxis-bot
reviewed
Aug 3, 2026
praxis-bot
left a comment
praxis-bot
left a comment
Collaborator
There was a problem hiding this comment.
Review: docs(proposals): add How? for pipeline info admin endpoint (#796)
Solid design section that aligns well with the existing PingoraAdminService architecture and the codebase's ListenerPipelines / ArcSwap<FilterPipeline> patterns. The technical claims about file paths, type names, trait methods, and admin exclusion are all accurate against the current codebase.
| Severity | Count |
|---|---|
| Large | 1 |
| Medium | 3 |
All findings have inline comments below.
…oxy#796) Describe GET /api/pipelines via existing admin dispatch, FilterPipeline introspection, JSON shape, and test plan. Signed-off-by: Hen Schwartz <hschwart@redhat.com>
henschwartz
force-pushed
the
docs/proposal-00796-how
branch
from
August 4, 2026 08:14
34778d6 to
ac10b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## How?section todocs/proposals/00796_pipeline-info-admin-endpoint.mdafter What?/Why? (docs(proposals): add pipeline info admin endpoint proposal #823) landed.GET /api/pipelineson existingPingoraAdminService,serde_json, loopback/allow_public_admin,ListenerPipelinesas live source,chain_names[], emptyfilters: []/filter_count: 0, and cheap per-listener queries.FilterPipelineintrospection, example JSON shape, reload edge cases, and unit/integration test plan for a future implementing PR.Test plan
proposal-checkallows How? on this follow-up (file is modified, not newly added)Related: #796, #793 (
praxisctl pipelinesconsumer later).