Issue 57 & 60: Add "-fork " and "-kafka" options #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 6, 2019 15:41
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
kmgowda
changed the title
Signed-off-by: Keshava Munegowda <[email protected]>
Signed-off-by: Keshava Munegowda <[email protected]>
RaulGracia
requested changes
Sep 24, 2019
Contributor
RaulGracia
left a comment
RaulGracia
left a comment
There was a problem hiding this comment.
Blocking for safety until reverting #63.
Contributor
|
Are the two options |
Contributor
Author
|
@maddisondavid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
A new option "-fork" option is added; by default it is set to True; if it is set to false, then new fixed thread pool is used.
Another new option "-kafka" is added; by default it is set to False; it it is set to true, then kafka bench-marking is conducted.
Purpose of the change
Fixes #57 , #60
What the code does
when user supplies -fork false; conventional thread pool is used; otherwise fork join pool is used.
when user supplied -kafka true; the kafka bench-marking is conducted.
Signed-off-by: Keshava Munegowda [email protected]