Skip to content

Conversation

@ngoyal16
Copy link

No description provided.

DeleteMessageBatch(context.Context,
*sqs.DeleteMessageBatchInput,
...func(*sqs.Options)) (*sqs.DeleteMessageBatchOutput, error)
ReceiveMessage(context.Context,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a point of having ReceiveMessage as part of this lib since SQS allows you to fetch upto 10 messages in a single batch as a blocking operation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but added few things like visiblity timeout and all so all the required function can be found at single place instead of using two different object for the same.


// DeleteBatchEnabled specifies that delete message dispatcher will
// be enabled or not. If not specified, defaults to false.
DeleteBatchEnabled bool
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I believe you're trying to use this package as a drop-in replacement for a standard AWS SDK. asyncsqs is meant to be used in conjunction with AWS SDK.

Copy link
Author

@ngoyal16 ngoyal16 Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exectly drop in replacement but helpful if user is using it then don't have to maintain two different objects places.

@ngoyal16
Copy link
Author

ngoyal16 commented Aug 25, 2023

@prashanthpai any update on same? or do i have to make any changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants