Skip to content

[WIP] Add mapping of scalable network modification to python #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

[WIP] Add mapping of scalable network modification to python #994

wants to merge 64 commits into from

Conversation

@nao1345678
Copy link
Contributor

@nao1345678 nao1345678 commented Apr 24, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #816
Fixes #993

@nao1345678 nao1345678 self-assigned this Apr 24, 2025
Naledi EL CHEIKH added 28 commits April 24, 2025 14:20
add : scale generator function impl cpp
d413c11 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add java impl
059db2f 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix java impl
46b6015 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add : add missed argument
42d0c6d 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
change in cpp
a7728f8 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
change in cpp
2503e1f 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
change in cpp for argument type
9631f0e 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
modification for proportional scalable
aab788d 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix style
efcd0c9 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
change in cpp for argument
cd1d1a4 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
scale proportional method parameters adjustment
b4f781b 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add : class for distribution mode in py impl
a8addcb 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test to change injections variable
50c774c 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test to change injections variable
f75574a 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test to change injections variable
c602f81 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
test to change injections variable
7a33262 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add missing parameter in cpp function
ae13be2 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add converting utility method for c entry point method
4180b01 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add converting utility method for c entry point method
159e0b6 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix error in method definition
54baeeb 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix error in bindings cpp
f115110 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add missing coma
c1fbfa9 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add missing const
51a24fe 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add failing test
fa761d8 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
sucessful test for proportional scale
fc301bc 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add check for injections
95d9505 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add scaling parameters
5d412b3 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix scaling parameters
6972da2 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Naledi EL CHEIKH added 9 commits June 2, 2025 11:43
delete enums scaling parameters
90a7dc4 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix enums
9da9440 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix enums
0ad830a 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix cpp
30dfaf3 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix cpp
e4bdcee 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix cpp
a478738 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix cpp
fc51115 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix unused imports
ef42241 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix missing coma in cpp
6619e9b 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed for 'pypowsybl'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Naledi EL CHEIKH added 14 commits June 4, 2025 14:21
add conversion methods for scalable for enums
82593ab 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix convert functions for scaling parameters
1a858f7 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix unused imports
2c1dfa1 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add scaling parameters as python object
610fc5c 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add test for parameters default values
052a1da 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix missing capital in test
ef5f6c0 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix missing coma
69707ef 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add failed tests
9739b2f 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix scaling convention variables names
c57b644 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix bindings cpp
64244fd 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix bindings cpp succesful test
0289ca3 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add scaling parameters to scaleProportional CFunctions
cbcd442 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
add scaling parameters impl to scale proportional impl
05c456f 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
fix scale tests
2d6ba93 
Signed-off-by: Naledi EL CHEIKH <[email protected]>
@nao1345678 nao1345678 force-pushed the scalable-network-modification branch from 69863bc to 2d6ba93 Compare June 16, 2025 12:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 25, 2025

Quality Gate Passed Quality Gate passed for 'pypowsybl-parent'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nao1345678 nao1345678

Labels

Release 12/2025

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scalable in pypowsybl : first POC Add the mapping to python of scalable network modification

3 participants

@nao1345678 @alicecaron