Skip to content

Conversation

@obrix
Copy link
Member

@obrix obrix commented Nov 21, 2025

Change the Rao API :
Add the possibility to load rao result from file to be used in monitoring call.
Add glsk parameter for run and monitoring for specific purposes.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@obrix obrix marked this pull request as draft November 21, 2025 16:16
@obrix
Copy link
Member Author

obrix commented Nov 26, 2025

Implements #1095 and #1096

@obrix obrix requested a review from bqth29 November 26, 2025 15:08
@obrix obrix marked this pull request as ready for review December 1, 2025 09:11
obrix added 15 commits December 1, 2025 10:14
…ring call. Add glsk parameter for run and monitoring for specific purpose.

Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
@obrix obrix force-pushed the rao_result_from_file_and_glsk_purpose branch from 81396cd to f1665cd Compare December 1, 2025 09:14
Copy link
Collaborator

@bqth29 bqth29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @obrix and thanks for your PR! I think it was very relevant to move the CRAC and the GLSK to the run method as it is both more intuitive and more Python-compliant.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Copy link
Collaborator

@bqth29 bqth29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! GitHub is reporting Sonar warnings, I don't know if they must be addressed now though

@obrix
Copy link
Member Author

obrix commented Dec 3, 2025

@bqth29 The warnings about the lambda cannot be fixed right now, we are doing this because of a graalvm limitation.
For the number of parameters in the run function this would complexify things a bit. I think we can let it as it is.
Thanks for the review!

@obrix obrix merged commit df6e545 into main Dec 3, 2025
10 checks passed
@obrix obrix deleted the rao_result_from_file_and_glsk_purpose branch December 3, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants