Run load flow with main synchronous component mode #1292
Conversation
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
SylvestreSakti
changed the base branch from
main
to
new_openloadflow_mainsynchronous
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
vidaldid-rte
changed the title
vidaldid-rte
force-pushed
the
new_openloadflow_mainsynchronous
branch
from
bf25059 to
a00e87b
Compare
Signed-off-by: Didier Vidal <[email protected]>
| .setBreakers(breakers) | ||
| .setPlausibleActivePowerLimit(lfParametersExt.getPlausibleActivePowerLimit()) | ||
| .setComputeMainConnectedComponentOnly(true) | ||
| .setComponentMode(lfParameters.getComponentMode()) |
There was a problem hiding this comment.
Did you change the behaviour on purpose ?
Per line 404 (in analyze) the DC sensitivity analysis seems to only run analysis on the main synchronous in reality.
There was a problem hiding this comment.
No this is indeed a mistake to be fixed, thanks.
| Network network = HvdcNetworkFactory.createVsc(); | ||
| LoadFlow.Runner loadFlowRunner = new LoadFlow.Runner(new OpenLoadFlowProvider(new DenseMatrixFactory())); | ||
| LoadFlowParameters parameters = new LoadFlowParameters(); | ||
|
|
There was a problem hiding this comment.
The test would provide more coverage if there was a disconnected component (ALL_COMPONENTS != MAIN_CONNECTED)
| assertEquals(4, lfResultMainConnected.getComponentResults().size()); // 4 SCs | ||
| assertEquals(1, lfResultMainSynchronous.getComponentResults().size()); // 1 SC | ||
|
|
||
| var saResultMainSynchronous = runSecurityAnalysis(network, Collections.emptyList(), createNetworkMonitors(network), lfParametersMainConnected); |
There was a problem hiding this comment.
Did you intend to run the test with lfParametersMainConnected although the result is called main Synchronous ?
Also, in addition to checking the result count, can you get at Bus result with a bus name that nelongs to the expected component, to be sure the computation occured on the expected component ?
vidaldid-rte
left a comment
vidaldid-rte
left a comment
There was a problem hiding this comment.
Few minor changes (on DC sensi, and on tests).
Will need the RC available, and Sonar and coverage result for final approval.
github-project-automation
bot
moved this from In Progress
to Waiting for review
in Release 12/2025
This PR cannot be merged before #1286 (Change of parameter name in core connectedComponentMode -> componentMode)
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#1279 (powsybl-open-loadflow)
powsybl/powsybl-core#3577 (powsybl-core)
What kind of change does this PR introduce?
This PR support the new introduced mode componentMode=MAIN_SYNCHRONOUS
What is the current behavior?
Only MAIN_CONNECTED and ALL_CONNECTED are supported. But for a main connected component that has multiple synchronous components, it is not possible to compute only the main synchronous component.
What is the new behavior (if this is a feature change)?
MAIN_CONNECTED, ALL_CONNECTED and MAIN_SYNCHRONOUS are supported
Does this PR introduce a breaking change or deprecate an API?