Support multithreading for AC sensitivity analysis #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
changed the title
vidaldid-rte
force-pushed
the
feature/sensi_mt
branch
2 times, most recently
from
be51bc9 to
c52497a
Compare
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
changed the title
vidaldid-rte
requested review from
FranckLecuyer,
SylvestreSakti,
geofjamg and
jeandemanged
and removed request for
FranckLecuyer,
SylvestreSakti and
jeandemanged
This comment was marked as outdated.
This comment was marked as outdated.
…ncy not in current batch Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
src/main/java/com/powsybl/openloadflow/sensi/mt/BufferedFactorReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/mt/BufferedFactorReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/mt/SequentialSensitivityResultWriter.java
Outdated
Show resolved
Hide resolved
…Reader.java Co-authored-by: Sylvestre Prabakaran <[email protected]> Signed-off-by: vidaldid-rte <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
src/main/java/com/powsybl/openloadflow/util/mt/ContingencyMultiThreadHelper.java
Outdated
Show resolved
Hide resolved
|
|
||
| // create networks including all necessary switches | ||
| lfNetworks = Networks.load(network, parameters.getNetworkParameters(), partitionTopoConfig, threadRootNode); | ||
| lfNetworksList.add(0, lfNetworks); // FIXME to workaround variant removal bug, to fix in core |
Member
There was a problem hiding this comment.
It was already like this before, but what is the reason to add at index 0 ? (which can be renamed addFirst())
Collaborator
Author
There was a problem hiding this comment.
Maybe the mytserious FIXME comment ?
I decided to be disciplined and keep the same thing to focus this PR on adding MT support to AC sensi.
Given that it is something odd, I would prefer to keep shocking Sonar and use this add API.
Member
There was a problem hiding this comment.
Outch I confirm, there was a bug in the network variant management (an error was throw, so something very explicit), but I don't remenber having fixed it in powsybl core... So I guess the bug is still there. Maybe to test again and to try creating a test case on core side ?
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
SylvestreSakti
approved these changes
Dec 3, 2025
github-project-automation
bot
moved this from In Progress
to Approved
in Release 12/2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Support multithreading for AC Sensitivity analysis
What is the current behavior?
AC sensnsitivity analysis can only be computed in single threaded mode
What is the new behavior (if this is a feature change)?
a sensitivity analysis param is added: thredaCount
If set with value higher than 1, contingencies are partionned with one partition per thread.
Each thread computes the SA for its partition.
Results are consolidated. It is not visible that they are run in MT unless you stream with the sensi writer and see them apperaing in an unordered way.
Does this PR introduce a breaking change or deprecate an API?