[WIP] Add integration of Reactiv Limits Outerloop #12

YoannAnezin · 2025-08-21T15:10:33Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverParameters.java

p-arvy · 2025-08-21T16:25:44Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+
+
+/**
+ * @author Martin Debouté {@literal <martin.deboute at artelys.com>}


Just precising that we will have to avoid such duplication. Instead, we will try to mutualize as much as possible the code. This will come later, but will need to be done before merge in main.

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

p-arvy · 2025-08-21T16:32:21Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+
+                        // Add complementarity constraints' variables
+                        varVSupIndices.add(compVarBaseIndex + 1); // V_sup
+                        varVSupIndices.add(compVarBaseIndex + 4); // sigma


p-arvy · 2025-08-21T16:41:46Z

src/test/java/com/powsybl/openloadflow/knitro/solver/ReactiveWithJacobienneTest.java

+ * @author Pierre Arvy {@literal <pierre.arvy at artelys.com>}
+ * @author Yoann Anezin {@literal <yoann.anezin at artelys.com>}
+ */
+public class ReactiveWithJacobienneTest {


Is there any real difference with ReactiveNoJacobienneTest file (only, of course, the usage or not of the jacobian matrix computed directly in your solver) ? If no, I think we can mutualize the file, and only change the setup function. This will avoid modifications in one file, that should be applied on both. Better for maintenance/limite the errors

src/test/java/com/powsybl/openloadflow/knitro/solver/ReactiveWithJacobienneTest.java

p-arvy · 2025-08-21T16:43:20Z

src/test/java/com/powsybl/openloadflow/knitro/solver/ReactiveNoJacobienneTest.java

@@ -0,0 +1,530 @@
+package com.powsybl.openloadflow.knitro.solver;


Please add Artelys copyrights. You can take them in any other file already in main and duplicate them (see last comment).

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

…mits Constraints Model implemented with Knitro Signed-off-by: Yoann Anezin <[email protected]>

…Constraints Model's, last commit before debugging Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

…Constraints Model's, and first tests Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

…Solver Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

…ith Q limits settled' writter and pertubation tests Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

p-arvy

Thanks for the work. Just some remarks on syntax/form.

p-arvy · 2025-09-19T09:37:32Z

pom.xml

        <java.version>17</java.version>
        <powsybl-core.version>6.6.0</powsybl-core.version>
-        <powsybl-open-loadflow.version>1.14.1</powsybl-open-loadflow.version>
+        <powsybl-open-loadflow.version>1.14.1-SNAPSHOTYA</powsybl-open-loadflow.version>


For testing this is ok. We'll have to change this before merging.

p-arvy · 2025-09-19T09:38:01Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroLoadFlowParameters.java

+    }
+
+    public KnitroLoadFlowParameters() {
+        this.knitroWritter = new KnitroWritter("Logs.txt");


Same, this will be removed before merging.

src/main/java/com/powsybl/openloadflow/knitro/solver/ReacLimitsTestsUtils.java

p-arvy · 2025-09-19T09:42:10Z

src/test/java/com/powsybl/openloadflow/knitro/solver/AcloadFlowReactiveLimitsTest.java

    @Test
    void test() {
-        parameters.setUseReactiveLimits(false);
+


Previous comment still applies

p-arvy · 2025-09-19T09:51:20Z

src/test/resources/logback-test.xml

-    <root level="DEBUG">
+
+    <appender name="ROLLING" class="ch.qos.logback.core.rolling.RollingFileAppender">
+        <file>D:/Documents/La_Doc/logrte1888.log</file> <!-- Chemin sans espace recommandé -->


Please remove the ChatGPT comment hehehe

p-arvy · 2025-09-19T09:52:53Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+        this.numVEquations = (int) (sortedEquations.stream().filter(e -> e.getType() == AcEquationType.BUS_TARGET_V).count());
+
+        int numSlackVariables = 2 * (numPEquations + numQEquations + numVEquations);
+        int complConstVariables = 5 * numVEquations;


explain in one line why please

why this number of complConstVariables

p-arvy · 2025-09-19T09:54:31Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+            List<Integer> jacobianRowIndices,
+            List<Integer> jacobianColumnIndices) {
+
+        int numberVEq = sortedEquationsToSolve.stream().filter(e ->


Don't think you need to convert as a list here. You can directly get the number you want from stream

p-arvy · 2025-09-19T09:56:44Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+            // Case of inactive Q equations
+            if (equationType == BUS_TARGET_Q && !equation.isActive()) {
+                compVarStart = vEquationLocalIds.getOrDefault(equationSystem.getIndex().getSortedEquationsToSolve()
+                        .indexOf(equationSystem.getEquations(ElementType.BUS, equation.getElementNum()).stream()


No way to get the BUS_TARGET_V equation with a simpler code here ?

p-arvy · 2025-09-19T10:08:42Z

src/main/java/com/powsybl/openloadflow/knitro/solver/KnitroSolverReacLim.java

+            }
+
+//            @Override
+//            public void evaluateGA(final List<Double> x, final List<Double> objGrad, final List<Double> jac) {


Please remove this

…ith Q limits settled' + maven correc Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

YoannAnezin requested a review from p-arvy August 21, 2025 15:10

p-arvy changed the base branch from main to feat/resilient-lf August 21, 2025 16:23

p-arvy reviewed Aug 21, 2025

View reviewed changes

YoannAnezin and others added 14 commits August 26, 2025 17:34

feat(solver): add a first version of the Resilient LF with Reactiv Li…

336078f

…mits Constraints Model implemented with Knitro Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Implementation of the Resilient LF with Reactiv Limits …

5da5022

…Constraints Model's, last commit before debugging Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Implementation of the Resilient LF with Reactiv Limits …

2afc091

…Constraints Model's, and first tests Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): First jacobienne implementation & tests

cc80abb

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Tests with and without jacobienne for the ReactiveLimit…

e7c36ca

…Solver Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Corrections

8f6ce92

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Corrections

5af9074

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Update Resilient Knitro Solver

548e96c

Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Tests with jacobienne

85b1f80

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

Change voltage upper limit to 5

c44f806

Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Scaling P, Q slack variables and tests with jacobienne

375945e

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Scaling P, Q slack variables and tests with jacobienne

3f802f8

Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Balance obj weights and get best feasible solution

5c93524

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): WIP

12f74c1

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

YoannAnezin force-pushed the feat/direct_integration_of_reactive_limits branch from c012a93 to 12f74c1 Compare August 28, 2025 16:36

YoannAnezin added 3 commits September 8, 2025 14:11

feat(solver): WIP Time computing optimization

57ca446

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): WIP Add Logs' writter and pertubation tests

808b299

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Correction of checker and considering only Q equation w…

5a37193

…ith Q limits settled' writter and pertubation tests Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

p-arvy reviewed Sep 19, 2025

View reviewed changes

YoannAnezin added 3 commits September 23, 2025 16:04

feat(solver): Correction of checker and considering only Q equation w…

04065be

…ith Q limits settled' + maven correc Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Add time spent in solver class

6483776

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>

feat(solver): Correction checker

1e83186

Signed-off-by: Yoann Anezin <[email protected]> Signed-off-by: Yoann Anezin <[email protected]>



		/**
		* @author Martin Debouté {@literal <martin.deboute at artelys.com>}

		@@ -0,0 +1,530 @@
		package com.powsybl.openloadflow.knitro.solver;

[WIP] Add integration of Reactiv Limits Outerloop #12

Are you sure you want to change the base?

[WIP] Add integration of Reactiv Limits Outerloop #12

Uh oh!

Conversation

YoannAnezin commented Aug 21, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

p-arvy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants