Add limit violation custom highlighting style support #729
+197
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayoub LABIDI <[email protected]>
SlimaneAmar
reviewed
Sep 22, 2025
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
...-diagram-core/src/main/java/com/powsybl/sld/svg/styles/iidm/LimitHighlightStyleProvider.java
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
network-area-diagram/src/main/java/com/powsybl/nad/svg/iidm/TopologicalStyleProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ayoub LABIDI <[email protected]>
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/add-limit-violation-custom-highlighting-support
branch
from
9249e32 to
574e7f2
Compare
|
SlimaneAmar
approved these changes
Sep 29, 2025
| // Check custom violations first | ||
| if (!limitViolationStyles.isEmpty()) { | ||
| String customStyle = limitViolationStyles.get(branchEdge.getEquipmentId()); | ||
| if (customStyle != null && !customStyle.isBlank()) { |
Contributor
There was a problem hiding this comment.
StringUtils.isBlank() ?
| */ | ||
| public class TopologicalStyleProvider extends AbstractVoltageStyleProvider { | ||
|
|
||
| private Map<String, String> limitViolationStyles = Map.of(); |
Contributor
There was a problem hiding this comment.
limitViolationStylesByBranchId ?
| for (Node node : edge.getNodes()) { | ||
| if (node instanceof FeederNode feederNode) { | ||
| String style = limitViolationStyles.get(feederNode.getEquipmentId()); | ||
| if (style != null && !style.isBlank()) { |
Contributor
There was a problem hiding this comment.
StringUtils.isBlank() ?
| */ | ||
| public class LimitHighlightStyleProvider extends EmptyStyleProvider { | ||
| private final Network network; | ||
| private Map<String, String> limitViolationStyles = Map.of(); |
Contributor
There was a problem hiding this comment.
limitViolationStylesByBranchId ?
github-project-automation
bot
moved this from In Progress
to Approved
in Release 09/2025
flo-dup
requested changes
Oct 21, 2025
| */ | ||
| public class LimitHighlightStyleProvider extends EmptyStyleProvider { | ||
| private final Network network; | ||
| private Map<String, String> limitViolationStyles = Map.of(); |
Collaborator
There was a problem hiding this comment.
there's a problem here, there's nothing which links these styles to limit violations here. Why didn't you include the logic which gives a style to a specific violation limit in this class? Similarly to isOverloaded method.
If you keep that map you should rather call it something like overrideStyles, but then why do include this in a LimitHighlight class? That could be in a separate one.
github-project-automation
bot
moved this from Approved
to Waiting for review
in Release 09/2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
A feature update adding customizable limit-violation styling logic
What is the current behavior?
Branch and edge styles rely solely on built-in overload detection without recognizing externally provided styles.
What is the new behavior (if this is a feature change)?
Both TopologicalStyleProvider and LimitHighlightStyleProvider now accept limitViolationStyles maps that supply explicit classes per equipment; when absent or blank they fall back to the existing overload-based styling
Does this PR introduce a breaking change or deprecate an API?