Skip to content

Conversation

@quinarygio
Copy link
Contributor

@quinarygio quinarygio commented Sep 12, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #683

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Giovanni Ferrari <[email protected]>
@quinarygio quinarygio linked an issue Sep 12, 2025 that may be closed by this pull request
@quinarygio quinarygio marked this pull request as draft September 12, 2025 12:29
@quinarygio quinarygio requested a review from flo-dup September 12, 2025 12:29
}

@Override
protected void addTeePoint(Terminal terminal) {
Copy link
Collaborator

@flo-dup flo-dup Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should not only create the tee point node, but also two FeederNode (one for each other line from the fictitious voltage level) and the two corresponding edges. In fact it should be very similar to NetworkGraphBuilder::addFeeder3wtNode

@quinarygio quinarygio marked this pull request as ready for review October 29, 2025 09:33
Signed-off-by: Giovanni Ferrari <[email protected]>
Signed-off-by: Giovanni Ferrari <[email protected]>
@sonarqubecloud
Copy link

@alicecaron alicecaron moved this from TODO to Issues in progress in Release 03/2026 Dec 10, 2025
@alicecaron alicecaron moved this from Issues in progress to In Progress in Release 03/2026 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Display tee-points inside voltage levels as an option

4 participants