Add method to check building inconsistency of Sparse Matrix#3912
Open
SylvestreSakti wants to merge 9 commits into
Open
Add method to check building inconsistency of Sparse Matrix#3912SylvestreSakti wants to merge 9 commits into
SylvestreSakti wants to merge 9 commits into
Conversation
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
…h repeated clear() reallocation Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Adding a new feature to check Sparse Matrix consistency.
An OLF bug (powsybl/powsybl-open-loadflow#1394) has been found and the cause was a wrong filling of the sparse matrices. Some rows were referenced multiple times in the same column without being detected. This check does not exist in the set() and add() method of the SparseMatrix class because it would cost too much performance (to check if row already exists at each update). Still this check seems necessary to detect earlier such failures.
Solution proposed is to check inconsistency at the end after having filled all the values of the matrix through a specific method.
What is the current behavior?
No checking method existing
What is the new behavior (if this is a feature change)?
A method is introduced to check
Does this PR introduce a breaking change or deprecate an API?