Fix BUS_BRANCH export failure with keepOriginalTopology#3905
Open
cphili wants to merge 3 commits into
Open
Conversation
…sent and keepOriginalTopology is enabled Signed-off-by: Clement Philipot <clement.philipot@rte-france.com>
cphili
changed the title
cphili
changed the title
Signed-off-by: Clement Philipot <clement.philipot@rte-france.com>
cphili
force-pushed
the
avoid_error_using_keeporiginaltopology
branch
from
07e9b8c to
68ffe1f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3851
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When exporting a network in IIDM format with BUS_BRANCH topology level and BUS_BRANCH_VOLTAGE_LEVEL_INCOMPATIBILITY_BEHAVIOR = KEEP_ORIGINAL_TOPOLOGY, the export may fail if a voltage level originally in NODE_BREAKER topology contains busbar sections. In such cases, terminal references may end up pointing to busbar sections while the voltage level is exported in BUS_BRANCH, resulting in a runtime exception during serialization.
What is the new behavior (if this is a feature change)?
When keepOriginalTopology is enabled, voltage levels whose native topology is NODE_BREAKER and which contain busbar sections are now automatically exported in NODE_BREAKER topology, even if the configured export topology level is BUS_BRANCH.
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
None
Other information: